OPENDJ-3529: NPE when connection is closed during handleAccept()

Yannick Lecaillez

25.46.2016 7974e68ba5e3396ea369b3522ab24ce9350c4633

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
/*
 * The contents of this file are subject to the terms of the Common Development and
 * Distribution License (the License). You may not use this file except in compliance with the
 * License.
 *
 * You can obtain a copy of the License at legal/CDDLv1.0.txt. See the License for the
 * specific language governing permission and limitations under the License.
 *
 * When distributing Covered Software, include this CDDL Header Notice in each file and include
 * the License file at legal/CDDLv1.0.txt. If applicable, add the following below the CDDL
 * Header, with the fields enclosed by brackets [] replaced by your own identifying
 * information: "Portions Copyright [year] [name of copyright owner]".
 *
 * Copyright 2008 Sun Microsystems, Inc.
 * Portions copyright 2012 ForgeRock AS.
 */
 
package org.forgerock.opendj.config;
 
import java.util.Comparator;
import java.util.List;
 
import org.forgerock.opendj.server.config.meta.RootCfgDefn;
import org.testng.annotations.DataProvider;
import org.testng.annotations.Test;
 
import static org.forgerock.opendj.config.ClassPropertyDefinition.*;
import static org.testng.Assert.*;
 
@SuppressWarnings("javadoc")
public class ClassPropertyDefinitionTest extends ConfigTestCase {
 
    /** Dummy class used in tests. */
    public static final class Dummy {
        public class X {
            // no implementation
        }
 
        public Comparator<Dummy> comparator() {
            return new Comparator<ClassPropertyDefinitionTest.Dummy>() {
                @Override
                public int compare(Dummy o1, Dummy o2) {
                    // No implementation required.
                    return 0;
                }
            };
        }
    }
 
    @DataProvider(name = "validClassNames")
    public Object[][] createBuilderAddInstanceOfData() {
        return new Object[][] {
            { "org.forgerock.opendj.config.ClassPropertyDefinitionTest" },
            { "org.forgerock.opendj.config.ClassPropertyDefinitionTest$Dummy" },
            { "org.forgerock.opendj.config.ClassPropertyDefinitionTest$Dummy$X" },
            { "org.forgerock.opendj.config.ClassPropertyDefinitionTest$Dummy$1" }, };
    }
 
    @Test(dataProvider = "validClassNames")
    public void testBuilderAddInstanceOf(String classNameToAdd) {
        ClassPropertyDefinition.Builder localBuilder = createBuilder(RootCfgDefn.getInstance(), "test-property");
        localBuilder.addInstanceOf(classNameToAdd);
        ClassPropertyDefinition propertyDef = localBuilder.getInstance();
        List<String> instances = propertyDef.getInstanceOfInterface();
        assertTrue(instances.contains(classNameToAdd));
    }
 
    @DataProvider(name = "invalidClassNames")
    public Object[][] createBuilderAddInstanceOfDataInvalid() {
        return new Object[][] {
            { "1" },
            { "" },
            { " " },
            { "  " },
            { "abc." },
            { "abc.123" },
            { "abc.123$" },
        };
    }
 
    @Test(dataProvider = "invalidClassNames", expectedExceptions = { IllegalArgumentException.class })
    public void testBuilderAddInstanceInvalid(String className) {
        ClassPropertyDefinition.Builder localBuilder = createBuilder(RootCfgDefn.getInstance(), "test-property");
        localBuilder.addInstanceOf(className);
        ClassPropertyDefinition propertyDef = localBuilder.getInstance();
        List<String> instances = propertyDef.getInstanceOfInterface();
        assertTrue(instances.contains(className));
    }
 
    /**
     * @return data for testing with illegal values
     */
    @DataProvider(name = "loadClasses")
    public Object[][] createLoadData() {
        return new Object[][] {
            { "java.io.Serializable", "java.lang.String", Object.class, String.class },
            { "java.io.Serializable", "java.lang.String", String.class, String.class },
            // abstractclass
            { "java.lang.Number", "java.lang.Long", Number.class, Long.class }, };
    }
 
    @Test(dataProvider = "loadClasses")
    public <T> void testLoadClass(String interfaceName, String loadClassName, Class<T> instanceOfClass,
            Class<?> expectedClass) {
        ClassPropertyDefinition.Builder localBuilder = createBuilder(RootCfgDefn.getInstance(), "test-property");
        localBuilder.addInstanceOf(interfaceName);
        ClassPropertyDefinition propertyDef = localBuilder.getInstance();
        Class<?> clazz = propertyDef.loadClass(loadClassName, instanceOfClass);
        assertEquals(clazz, expectedClass);
    }
 
    @DataProvider(name = "loadClassesIllegal")
    public Object[][] createLoadDataIllegal() {
        return new Object[][] {
            { "java.lang.Runnable", "java.lang.String", Object.class, String.class },
            { "java.lang.Runnable", "some.bogus.ClassName", Object.class, String.class },
            { "java.lang.Runnable", "java.lang.String", Number.class, Number.class }, };
    }
 
    @Test(dataProvider = "loadClassesIllegal", expectedExceptions = { PropertyException.class })
    public <T> void testLoadClassIllegal(String interfaceName, String loadClassName, Class<T> instanceOfClass,
            Class<?> expectedClass) {
        ClassPropertyDefinition.Builder localBuilder = createBuilder(RootCfgDefn.getInstance(), "test-property");
        localBuilder.addInstanceOf(interfaceName);
        ClassPropertyDefinition propertyDef = localBuilder.getInstance();
        Class<?> clazz = propertyDef.loadClass(loadClassName, instanceOfClass);
        assertEquals(clazz, String.class);
    }
 
}