Fix CodeQL warning-severity alerts: dead checks, boxed locals and three nul...

Valery Kharseko

yesterday 504a43fc479d884085df9895900608dc5b0aca6f

 opendj-config/src/main/java/org/forgerock/opendj/config/dsconfig/BuildVersion.java

@@ -13,6 +13,7 @@
 *
 * Copyright 2008 Sun Microsystems, Inc.
 * Portions Copyright 2013-2016 ForgeRock AS.
 * Portions Copyright 2026 3A Systems, LLC.
 */
package org.forgerock.opendj.config.dsconfig;

@@ -191,11 +192,8 @@
        if (major == version.major) {
            if (minor == version.minor) {
                if (point == version.point) {
                    if (rev == version.rev) {
                        return 0;
                    } else if (rev.compareTo(version.rev) < 0) {
                        return -1;
                    }
                    // Compares the revisions as strings: they are VCS revisions, not numbers.
                    return Integer.signum(rev.compareTo(version.rev));
                } else if (point < version.point) {
                    return -1;
                }