Enforced ReplicationServerDomain responsibilities by increasing encapsulation.

Jean-Noel Rouvignac

19.32.2013 c63e1f305327734be21f5ce0e21bdd2f7a4d143b

 opendj-sdk/opends/src/server/org/opends/server/replication/server/DataServerHandler.java

@@ -229,14 +229,6 @@
    return newStatus;
  }

  private void createStatusAnalyzer()
  {
    if (!replicationServerDomain.isRunningStatusAnalyzer())
    {
      replicationServerDomain.startStatusAnalyzer();
    }
  }

  /**
   * Retrieves a set of attributes containing monitor data that should be
   * returned to the client if the corresponding monitor entry is requested.
@@ -457,8 +449,7 @@
      localGenerationId = replicationServerDomain.getGenerationId();
      oldGenerationId = localGenerationId;

      // Duplicate server ?
      if (!replicationServerDomain.checkForDuplicateDS(this))
      if (replicationServerDomain.isAlreadyConnectedToDS(this))
      {
        abortStart(null);
        return;
@@ -468,7 +459,6 @@
      {
        StartMsg outStartMsg = sendStartToRemote();

        // log
        logStartHandshakeRCVandSND(inServerStartMsg, outStartMsg);

        // The session initiator decides whether to use SSL.
@@ -508,11 +498,8 @@
        throw new DirectoryException(ResultCode.OTHER, null, null);
      }

      // Create the status analyzer for the domain if not already started
      createStatusAnalyzer();

      // Create the monitoring publisher for the domain if not already started
      createMonitoringPublisher();
      replicationServerDomain.startStatusAnalyzer();
      replicationServerDomain.startMonitoringPublisher();

      registerIntoDomain();