Code cleanup after running Findbugs. Remove useless initializations, useles...

Ludovic Poitou

22.21.2012 36f15683bbdb78aa429defa97d1a6c26d03eb9b9

 opendj-sdk/opends/src/server/org/opends/server/replication/server/MonitorData.java

@@ -23,6 +23,7 @@
 *
 *
 *      Copyright 2009-2010 Sun Microsystems, Inc.
 *      Portions Copyright 2012 ForgeRock AS
 */
package org.opends.server.replication.server;

@@ -179,9 +180,12 @@
          int missingChangesLsiLsj =
            ChangeNumber.diffSeqNum(lsjMaxCN, lsiLastCN);

          mds +=
            "+ diff("+lsjMaxCN+"-"
                     +lsiLastCN+")="+missingChangesLsiLsj;
          if (debugEnabled())
          {
            mds +=
              "+ diff("+lsjMaxCN+"-"
                       +lsiLastCN+")="+missingChangesLsiLsj;
          }

          // Regarding a DS that is generating changes. If it is a local DS1,
          // we get its server state, store it, then retrieve server states of
@@ -197,14 +201,20 @@
            if (missingChangesLsiLsj <= 50)
            {
              missingChangesLsiLsj = 0;
              mds += " (diff replaced by 0 as for server id " + lsiSid + ")";
              if (debugEnabled())
              {
                mds += " (diff replaced by 0 as for server id " + lsiSid + ")";
              }
            }
          }

          lsiMissingChanges += missingChangesLsiLsj;
        }
      }
      mds += "=" + lsiMissingChanges;
      if (debugEnabled())
      {
        mds += "=" + lsiMissingChanges;
      }
      this.missingChanges.put(lsiSid,lsiMissingChanges);
    }

@@ -227,19 +237,26 @@
          int missingChangesLsiLsj =
            ChangeNumber.diffSeqNum(lsjMaxCN, lsiLastCN);

          mds +=
            "+ diff("+lsjMaxCN+"-"
                     +lsiLastCN+")="+missingChangesLsiLsj;

          if (debugEnabled())
          {
            mds +=
              "+ diff("+lsjMaxCN+"-"
                       +lsiLastCN+")="+missingChangesLsiLsj;
          }
          lsiMissingChanges += missingChangesLsiLsj;
        }
      }
      mds += "=" + lsiMissingChanges;
      if (debugEnabled())
      {
        mds += "=" + lsiMissingChanges;
      }
      this.missingChangesRS.put(lsiSid,lsiMissingChanges);

      if (debugEnabled())
      {
        TRACER.debugInfo(
          "Complete monitor data : Missing changes ("+ lsiSid +")=" + mds);
      }
    }
    }