Code cleanups

Jean-Noel Rouvignac

07.48.2015 a85ac03de14ecb36a2a18558b47ef7d31462c073

 opendj-server-legacy/src/main/java/org/opends/admin/ads/TopologyCache.java

@@ -518,33 +518,8 @@
              && replica.getReplicationId() == replicaId)
          {
            // This statistic is optional.
            String s = ConnectionUtils.getFirstValue(sr,
                "approx-older-change-not-synchronized-millis");
            if (s != null)
            {
              try
              {
                replica.setAgeOfOldestMissingChange(Long.valueOf(s));
              }
              catch (Throwable t)
              {
                logger.warn(LocalizableMessage.raw(
                    "Unexpected error reading age of oldest change: " + t, t));
              }
            }
            s = ConnectionUtils.getFirstValue(sr, "missing-changes");
            if (s != null)
            {
              try
              {
                replica.setMissingChanges(Integer.valueOf(s));
              }
              catch (Throwable t)
              {
                logger.warn(LocalizableMessage.raw(
                    "Unexpected error reading missing changes: " + t, t));
              }
            }
            setAgeOfOldestMissingChange(replica, sr);
            setMissingChanges(replica, sr);
            updatedReplicas.add(replica);
          }
        }
@@ -573,4 +548,38 @@
      }
    }
  }

  private void setMissingChanges(ReplicaDescriptor replica, SearchResult sr) throws NamingException
  {
    String s = ConnectionUtils.getFirstValue(sr, "missing-changes");
    if (s != null)
    {
      try
      {
        replica.setMissingChanges(Integer.valueOf(s));
      }
      catch (Throwable t)
      {
        logger.warn(LocalizableMessage.raw(
            "Unexpected error reading missing changes: " + t, t));
      }
    }
  }

  private void setAgeOfOldestMissingChange(ReplicaDescriptor replica, SearchResult sr) throws NamingException
  {
    String s = ConnectionUtils.getFirstValue(sr, "approx-older-change-not-synchronized-millis");
    if (s != null)
    {
      try
      {
        replica.setAgeOfOldestMissingChange(Long.valueOf(s));
      }
      catch (Throwable t)
      {
        logger.warn(LocalizableMessage.raw(
            "Unexpected error reading age of oldest change: " + t, t));
      }
    }
  }
}