Fix CodeQL note-severity alerts: deprecated JDK calls and inefficient expre...

Valery Kharseko

11 hours ago 9b22e6c88920b4d06ff0a8a67153452f8fd1bd1b

 opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/BackupPanel.java

@@ -13,6 +13,7 @@
 *
 * Copyright 2008-2009 Sun Microsystems, Inc.
 * Portions Copyright 2014-2016 ForgeRock AS.
 * Portions Copyright 2026 3A Systems, LLC.
 */
package org.opends.guitools.controlpanel.ui;

@@ -371,7 +372,7 @@
    }

    String parentPath = parentDirectory.getText();
    if (parentPath == null || parentPath.trim().equals(""))
    if (parentPath == null || parentPath.trim().isEmpty())
    {
      errors.add(ERR_CTRL_PANEL_NO_BACKUP_PATH_PROVIDED.get());
      setPrimaryInvalid(lPath);
@@ -391,7 +392,7 @@
      }
    }
    String dir = backupID.getText();
    if (dir == null || dir.trim().equals(""))
    if (dir == null || dir.trim().isEmpty())
    {
      errors.add(ERR_CTRL_PANEL_NO_BACKUP_ID_PROVIDED.get());
      setPrimaryInvalid(lBackupID);
@@ -422,7 +423,7 @@
      else
      {
        String parentID = parentBackupID.getText();
        if (parentID == null || parentID.trim().equals(""))
        if (parentID == null || parentID.trim().isEmpty())
        {
          errors.add(ERR_CTRL_PANEL_NO_PARENT_BACKUP_ID_PROVIDED.get());
          setPrimaryInvalid(lParentID);