OPENDJ-1802 Make ByteString methods more intentional

Jean-Noël Rouvignac

29.51.2015 4baece95779dd46a3a59d59d1b7aa5958cf6117d

 opendj-server-legacy/src/main/java/org/opends/server/backends/SchemaBackend.java

@@ -250,8 +250,8 @@
    cfg.getBaseDN().toArray(newBaseDNs);
    this.baseDNs = newBaseDNs;

    creatorsName  = ByteString.valueOf(newBaseDNs[0].toString());
    modifiersName = ByteString.valueOf(newBaseDNs[0].toString());
    creatorsName  = ByteString.valueOfUtf8(newBaseDNs[0].toString());
    modifiersName = ByteString.valueOfUtf8(newBaseDNs[0].toString());

    long createTime = DirectoryServer.getSchema().getOldestModificationTime();
    createTimestamp =
@@ -1152,7 +1152,7 @@
      authzDN = DN.rootDN();
    }

    modifiersName = ByteString.valueOf(authzDN.toString());
    modifiersName = ByteString.valueOfUtf8(authzDN.toString());
    modifyTimestamp = GeneralizedTimeSyntax.createGeneralizedTimeValue(
                           System.currentTimeMillis());
  }
@@ -2870,7 +2870,7 @@
    {
      if (schemaFile.equals(getSchemaFile(ldapSyntax)))
      {
        values.add(ByteString.valueOf(ldapSyntax.toString()));
        values.add(ByteString.valueOfUtf8(ldapSyntax.toString()));
      }
    }

@@ -2934,7 +2934,7 @@
      {
        if (schemaFile.equals(getSchemaFile(nf)))
        {
          values.add(ByteString.valueOf(nf.toString()));
          values.add(ByteString.valueOfUtf8(nf.toString()));
        }
      }
    }
@@ -2955,7 +2955,7 @@
    {
      if (schemaFile.equals(getSchemaFile(dcr)))
      {
        values.add(ByteString.valueOf(dcr.toString()));
        values.add(ByteString.valueOfUtf8(dcr.toString()));
      }
    }

@@ -2997,7 +2997,7 @@
    {
      if (schemaFile.equals(getSchemaFile(mru)))
      {
        values.add(ByteString.valueOf(mru.toString()));
        values.add(ByteString.valueOfUtf8(mru.toString()));
      }
    }

@@ -3077,7 +3077,7 @@
                              addedTypes, depth+1);
    }

    values.add(ByteString.valueOf(attributeType.toString()));
    values.add(ByteString.valueOfUtf8(attributeType.toString()));
    addedTypes.add(attributeType);
  }

@@ -3127,7 +3127,7 @@
                                   addedClasses, depth+1);
      }
    }
    values.add(ByteString.valueOf(objectClass.toString()));
    values.add(ByteString.valueOfUtf8(objectClass.toString()));
    addedClasses.add(objectClass);
  }

@@ -3177,7 +3177,7 @@
      }
    }

    values.add(ByteString.valueOf(ditStructureRule.toString()));
    values.add(ByteString.valueOfUtf8(ditStructureRule.toString()));
    addedDSRs.add(ditStructureRule);
  }