Refactor file deletion logic to combine null check and length check. (#653)

Valery Kharseko

17 hours ago 6276e024caa4d56aae2c50e80cb104b7bde3b7c4

 opendj-server-legacy/src/main/java/org/opends/server/loggers/FileNumberRetentionPolicy.java

@@ -13,6 +13,7 @@
 *
 * Copyright 2006-2008 Sun Microsystems, Inc.
 * Portions Copyright 2014-2016 ForgeRock AS.
 * Portions Copyright 2026 3A Systems, LLC
 */
package org.opends.server.loggers;
import static org.opends.messages.LoggerMessages.*;
@@ -75,13 +76,8 @@
      throws DirectoryException
  {
    File[] files = fileNamingPolicy.listFiles();
    if(files == null)
    {
      throw new DirectoryException(DirectoryServer.getCoreConfigManager().getServerErrorResultCode(),
          ERR_LOGGER_ERROR_LISTING_FILES.get(fileNamingPolicy.getInitialName()));
    }

    if (files.length <= numFiles)
    if (files == null || files.length <= numFiles)
    {
      return new File[0];
    }