OPENDJ-2327: Improve log messages on certain 'server error' disconnects

ian.packer

27.46.2015 25669bf85e5f2bb3f9ba5a6c9c43e149b07095a9

 opendj-server-legacy/src/main/java/org/opends/server/protocols/ldap/LDAPRequestHandler.java

@@ -289,27 +289,13 @@
              {
                clientConnection = (LDAPClientConnection) key.attachment();

                try
                int readResult = clientConnection.processDataRead();
                if (readResult < 0)
                {
                  int readResult = clientConnection.processDataRead();
                  if (readResult < 0)
                  {
                    key.cancel();
                  }
                  if (readResult > 0) {
                    readyConnections.add(clientConnection);
                  }
                }
                catch (Exception e)
                {
                  logger.traceException(e);

                  // Some other error occurred while we were trying to read data
                  // from the client.
                  // FIXME -- Should we log this?
                  key.cancel();
                  clientConnection.disconnect(DisconnectReason.SERVER_ERROR,
                                              false, null);
                }
                if (readResult > 0) {
                  readyConnections.add(clientConnection);
                }
              }
              catch (Exception e)
@@ -323,8 +309,8 @@

                if (clientConnection != null)
                {
                  clientConnection.disconnect(DisconnectReason.SERVER_ERROR,
                                              false, null);
                  clientConnection.disconnect(DisconnectReason.SERVER_ERROR, false,
                      ERR_UNEXPECTED_EXCEPTION_ON_CLIENT_CONNECTION.get(getExceptionMessage(e)));
                }
              }
            }