Improvements suggested by UCDetector: remove dead code, add final keywords,...

Jean-Noël Rouvignac

22.56.2016 83f86f11c27378d650c3bfc7e55397687062edbc

 opendj-server-legacy/src/test/java/org/opends/server/replication/plugin/ModifyConflictTest.java

@@ -24,6 +24,7 @@

import org.forgerock.opendj.ldap.AttributeDescription;
import org.forgerock.opendj.ldap.ByteString;
import org.forgerock.opendj.ldap.DN;
import org.forgerock.opendj.ldap.ModificationType;
import org.forgerock.opendj.ldap.schema.AttributeType;
import org.opends.server.core.DirectoryServer;
@@ -36,7 +37,6 @@
import org.opends.server.types.Attribute;
import org.opends.server.types.AttributeBuilder;
import org.opends.server.types.Attributes;
import org.forgerock.opendj.ldap.DN;
import org.opends.server.types.DirectoryException;
import org.opends.server.types.Entry;
import org.opends.server.types.Modification;
@@ -1093,8 +1093,7 @@
    if (fks.iterator().hasNext())
    {
      FakeOperation fk = fks.iterator().next();
      assertEquals(new FakeOperationComparator().compare(fk, fk), 0);
      assertTrue(new FakeOperationComparator().compare(null, fk) < 0);
      assertEquals(fk.getCSN().compareTo(fk.getCSN()), 0);
      ReplicationMsg generatedMsg = fk.generateMessage();
      if (generatedMsg instanceof LDAPUpdateMsg)
      {