Another fix for OpenDJ-97: Very many minor problems with the error logging ...

Matthew Swift

14.24.2011 fdd4869955da5a5f181d0d44756d3da0bdd35594

 opends/src/server/org/opends/server/replication/service/ReplicationBroker.java

@@ -2601,15 +2601,21 @@
              {
                // The best replication server is no more the one we are
                // currently using. Disconnect properly then reconnect.
                int bestServerId = -1;
                if (bestServerInfo != null)
                Message message;
                if (bestServerInfo == null)
                {
                  bestServerId = bestServerInfo.getServerId();
                  message = NOTE_LOAD_BALANCE_REPLICATION_SERVER.get(
                      serverId, replicationServerID,
                      failingSession.getReadableRemoteAddress(),
                      baseDn);
                }
                Message message = NOTE_NEW_BEST_REPLICATION_SERVER
                    .get(serverId, replicationServerID,
                        failingSession.getReadableRemoteAddress(),
                        bestServerId, baseDn);
                else
                {
                  message = NOTE_NEW_BEST_REPLICATION_SERVER.get(
                      serverId, replicationServerID,
                      failingSession.getReadableRemoteAddress(),
                      bestServerInfo.getServerId(), baseDn);
                }
                logError(message);
                reStart(true);
              }