mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noël Rouvignac
28.11.2015 0364afd608de95af991df681c3f952467b7c67ad
refs
author Jean-Noël Rouvignac <jean-noel.rouvignac@forgerock.com>
Wednesday, October 28, 2015 09:11 +0100
committer Jean-Noël Rouvignac <jean-noel.rouvignac@forgerock.com>
Tuesday, November 3, 2015 17:49 +0100
commit0364afd608de95af991df681c3f952467b7c67ad
tree 24192af8cd32cf7541f008394004a84ca70961a9 tree | zip | gz
parent d3e67bec3bdc1be79bb1089177c8409630eb992c view | diff
OPENDJ-1802 Make ByteStringBuilder methods more intentional

ByteStringBuilder.java:
Changed:
- append(byte) to appendByte(int)
- append(short) to appendShort(int)
- append(int) to appendInt(int)
- append(long) to appendLong(long)
- append(Object) to appendObject(Object)
- append(String) to appendUtf8(String)
- append(char[]) to appendUtf8(char[])
- All remaining append() to appendBytes().
I changed appendByte() and appendShort() to accept int parameters.
This avoids continuously casting, at the expense of a possible loss of the high bits.
24 files modified
515 ■■■■ changed files
opendj-sdk/opendj-core/clirr-ignored-api-changes.xml 20 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/main/java/org/forgerock/opendj/io/ASN1ByteSequenceReader.java 2 ●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/main/java/org/forgerock/opendj/io/ASN1InputStreamReader.java 2 ●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/main/java/org/forgerock/opendj/ldap/AVA.java 10 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/main/java/org/forgerock/opendj/ldap/Base64.java 12 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/main/java/org/forgerock/opendj/ldap/ByteString.java 5 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/main/java/org/forgerock/opendj/ldap/ByteStringBuilder.java 107 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/main/java/org/forgerock/opendj/ldap/DN.java 2 ●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/main/java/org/forgerock/opendj/ldap/Filter.java 4 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/main/java/org/forgerock/opendj/ldap/RDN.java 4 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/main/java/org/forgerock/opendj/ldap/schema/AbstractSubstringMatchingRuleImpl.java 19 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/main/java/org/forgerock/opendj/ldap/schema/CertificateExactMatchingRuleImpl.java 27 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/main/java/org/forgerock/opendj/ldap/schema/IntegerOrderingMatchingRuleImpl.java 32 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/main/java/org/forgerock/opendj/ldap/schema/TimeBasedMatchingRulesImpl.java 6 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/main/java/org/forgerock/opendj/ldap/schema/UUIDEqualityMatchingRuleImpl.java 2 ●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/main/java/org/forgerock/opendj/ldap/schema/UniqueMemberEqualityMatchingRuleImpl.java 4 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/main/java/org/forgerock/opendj/ldif/AbstractLDIFReader.java 2 ●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/test/java/org/forgerock/opendj/io/ASN1ReaderTestCase.java 22 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/test/java/org/forgerock/opendj/ldap/ByteSequenceReaderTest.java 6 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/test/java/org/forgerock/opendj/ldap/ByteStringBuilderTestCase.java 78 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/test/java/org/forgerock/opendj/ldap/ByteStringTestCase.java 12 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/test/java/org/forgerock/opendj/ldap/schema/IntegerOrderingMatchingRuleTest.java 2 ●●● diff | view | raw | blame | history
opendj-sdk/opendj-grizzly/src/main/java/org/forgerock/opendj/grizzly/ASN1BufferReader.java 8 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-grizzly/src/main/java/org/forgerock/opendj/grizzly/ASN1BufferWriter.java 127 ●●●● diff | view | raw | blame | history