mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noël Rouvignac
28.10.2015 07e7cb84f497a907074b5ca46f3147f65488d6ed
refs
author Jean-Noël Rouvignac <jean-noel.rouvignac@forgerock.com>
Wednesday, October 28, 2015 10:10 +0100
committer Jean-Noël Rouvignac <jean-noel.rouvignac@forgerock.com>
Thursday, November 5, 2015 13:25 +0100
commit07e7cb84f497a907074b5ca46f3147f65488d6ed
tree 4927cfdccafde8a27ed7829a8359dbdc8073173b tree | zip | gz
parent 90f97a8328fb2433989b4ac05dd565dc6b4db4bc view | diff
OPENDJ-1802 Make ByteStringBuilder methods more intentional

ByteStringBuilder.java:
Changed:
- append(byte) to appendByte(int)
- append(short) to appendShort(int)
- append(int) to appendInt(int)
- append(long) to appendLong(long)
- append(Object) to appendObject(Object)
- append(String) to appendUtf8(String)
- append(char[]) to appendUtf8(char[])
- All remaining append() to appendBytes().
I changed appendByte() and appendShort() to accept int parameters.
This avoids continuously casting, at the expense of a possible loss of the high bits.

ByteStringBuilder.java: appendBytes(), appendUtf8(), appendObject()
50 files modified
450 ■■■■ changed files
opendj-server-legacy/src/dsml/org/opends/dsml/protocol/ByteStringUtility.java 2 ●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/util/RemoteSchemaLoader.java 4 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/api/CompressedSchema.java 6 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/backends/jeb/DBTest.java 2 ●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/backends/jeb/DN2URI.java 6 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/backends/jeb/ID2Entry.java 2 ●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/backends/jeb/JebFormat.java 2 ●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/backends/jeb/SortValuesSet.java 2 ●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/backends/jeb/VLVIndex.java 4 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/DN2ID.java 4 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/DN2URI.java 10 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/DnKeyFormat.java 10 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/EntryIDSet.java 6 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/ID2Entry.java 2 ●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/VLVIndex.java 12 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/protocols/internal/InternalLDAPOutputStream.java 2 ●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/protocols/ldap/ASN1ByteChannelReader.java 4 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/protocols/ldap/LDAPFilter.java 20 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/replication/common/CSN.java 3 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/replication/plugin/HistoricalCsnOrderingMatchingRuleImpl.java 12 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/replication/protocol/AddMsg.java 2 ●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/replication/protocol/ByteArrayBuilder.java 24 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/replication/protocol/LDAPUpdateMsg.java 2 ●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/replication/protocol/MonitorMsg.java 4 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/replication/protocol/StartMsg.java 8 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/replication/protocol/StartSessionMsg.java 10 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/replication/protocol/TopologyMsg.java 6 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/replication/protocol/UpdateMsg.java 5 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/replication/server/changelog/file/BlockLogReader.java 10 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/replication/server/changelog/file/BlockLogWriter.java 4 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/replication/server/changelog/file/FileChangeNumberIndexDB.java 9 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/tools/upgrade/Installation.java 2 ●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/types/DN.java 14 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/types/Entry.java 14 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/types/EntryEncodeConfig.java 2 ●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/types/RDN.java 18 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/types/RecordingInputStream.java 7 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/types/RecordingOutputStream.java 7 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/types/SearchFilter.java 20 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/util/LDIFReader.java 2 ●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/quicksetup/TestUtilities.java 4 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/api/AuthenticationPolicyTestCase.java 8 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/backends/jeb/TestJebFormat.java 28 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/backends/pluggable/OnDiskMergeImporterTest.java 4 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/backends/pluggable/TestDnKeyFormat.java 28 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/extensions/PlainSASLMechanismHandlerTestCase.java 50 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/protocols/ldap/ASN1ReaderTestCase.java 18 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/replication/server/changelog/file/BlockLogReaderWriterTest.java 2 ●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/replication/server/changelog/file/LogFileTest.java 19 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/types/TestDN.java 4 ●●●● diff | view | raw | blame | history