mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Gaetan Boismal
23.46.2016 08a8540072a370b4e7e9604eb97818dcfd4d74c6
refs
author Gaetan Boismal <gaetan.boismal@forgerock.com>
Friday, September 23, 2016 16:46 +0200
committer Gaetan Boismal <gaetan.boismal@forgerock.com>
Monday, October 31, 2016 15:00 +0100
commit08a8540072a370b4e7e9604eb97818dcfd4d74c6
tree 3c092140be361d3ce4d4e4e6d9c57c4c3051a99d tree | zip | gz
parent caf74d75e44a4769e6d4489970838703eedb745f view | diff
OPENDJ-2773 Remove duplicated server tools

Once sdk ldap toolkit tools have been merged with the server ones, we are now able to remove the following tools from opendj-server-legacy module:
* base64
* Removes whole class. Replaced by SDK's Base64 which is noew public
* ldapcompare
* Removes whole class and adapts test cases usages to the sdk ldapcompare options
* ldapdelete
* Removes whole class and adapts test cases usages to the sdk ldapcompare options
* ldapmodify
* Removes whole class and adapts test cases usages to the sdk ldapcompare options
* Removes -a option since it does not exist in the sdk because it's the default behavior
* Removes support of ChangeNumber control decoding and printing since it was a specific DJ one.
* ldappasswordmodify
* Removes whole class and adapts test cases usages to the sdk ldapcompare options
* When noop control is used, tool return code is now 0 instead of 16654, apdats unit test in consequence.
* ldapsearch
* Removes whole class and adapts test cases usages to the sdk ldapcompare options
* Replace -r argument by -o mech=EXTERNAL because -r has been removed in the sdk
* Always use -N argument to provide client certificate nickname ('client-cert' in unit tests) when -o mech=EXTERNAL (SASL external Bind) is used since the server default behavior to take the first client certificate from the client keystore has not been keeped.
* When SSL is used in used tests we do not have hostname matching between certificate's cn (cn=OpenDJ Server Certificate) and the one given in ldap* tool -h argument (127.0.0.1).
SDK tools prompts user to know what they want to do in such cases (if the -X, --trustAll flag has not been provided on the command line). Modified impacted unit tests to trust the certificate for the session only. As it's the default value, we just need to hit enter key on stdin.
* We do not support -o mech=ANONYMOUS in the sdk. So this parameter has been removed from server's unit tests.
* ldif* tools
* Removes whole class and adapts test cases usages to the sdk ldapcompare options

* Changes performed in source code files to avoid depending on opendj-ldap-toolkit.jar
* ConfigurationHandler.java
* Use sdk LDIF* apis to perform the modify instead of the tool.
* NewBaseDNPanel.java
* Use ldapmodify script located under in bin/ folder instead of programmatically. This is way no ideal but this code is so difficult to manage as it's a best effort situation here.
* src/main/java/org/opends/guitools/controlpanel/task/ResetUserPasswordTask.java
* Use sdk connection to perform the password modify extended request instead of using the tool.
* opendj-server-legacy/pom.xml
* Add a dependency on opendj-ldap-toolkit.
Note that transitive dependancies are correctly moved in the lib/ archive folder and bootstrap-client jar is correcly updated.
34 files deleted
1 files added
82 files modified
11537 ■■■■■ changed files
opendj-core/src/main/java/org/forgerock/opendj/ldap/Base64.java 22 ●●●● diff | view | raw | blame | history
opendj-core/src/test/java/org/forgerock/opendj/ldap/TestBase64.java 190 ●●●●● diff | view | raw | blame | history
opendj-dsml-servlet/src/main/java/org/opends/dsml/protocol/DSMLServlet.java 8 ●●●● diff | view | raw | blame | history
opendj-server-legacy/pom.xml 6 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/resource/bin/base64 27 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/resource/bin/base64.bat 23 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/resource/bin/ldapcompare 27 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/resource/bin/ldapcompare.bat 23 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/resource/bin/ldapdelete 27 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/resource/bin/ldapdelete.bat 23 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/resource/bin/ldapmodify 28 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/resource/bin/ldapmodify.bat 23 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/resource/bin/ldappasswordmodify 27 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/resource/bin/ldappasswordmodify.bat 23 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/resource/bin/ldapsearch 27 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/resource/bin/ldapsearch.bat 23 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/resource/bin/ldif-diff 27 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/resource/bin/ldif-diff.bat 24 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/resource/bin/ldifmodify 27 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/resource/bin/ldifmodify.bat 23 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/resource/bin/ldifsearch 27 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/resource/bin/ldifsearch.bat 23 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/datamodel/BinaryValue.java 4 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/ResetUserPasswordTask.java 82 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/JavaPropertiesPanel.java 4 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/NewBaseDNPanel.java 13 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/ViewEntryPanel.java 2 ●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/config/ConfigurationHandler.java 40 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/crypto/CryptoManagerImpl.java 4 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/extensions/AESPasswordStorageScheme.java 6 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/extensions/Base64PasswordStorageScheme.java 4 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/extensions/BlowfishPasswordStorageScheme.java 10 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/extensions/MD5PasswordStorageScheme.java 4 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/extensions/PBKDF2PasswordStorageScheme.java 8 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/extensions/PKCS5S2PasswordStorageScheme.java 8 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/extensions/RC4PasswordStorageScheme.java 10 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/extensions/SHA1PasswordStorageScheme.java 4 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/extensions/SaltedMD5PasswordStorageScheme.java 8 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/extensions/SaltedSHA1PasswordStorageScheme.java 10 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/extensions/SaltedSHA256PasswordStorageScheme.java 8 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/extensions/SaltedSHA384PasswordStorageScheme.java 8 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/extensions/SaltedSHA512PasswordStorageScheme.java 10 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/extensions/TripleDESPasswordStorageScheme.java 10 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/loggers/TextAuditLogPublisher.java 2 ●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/protocols/ldap/AddRequestProtocolOp.java 4 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/protocols/ldap/SearchResultEntryProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/schema/SchemaFilesWriter.java 4 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/tools/ConfigureWindowsService.java 2 ●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPAuthenticationHandler.java 2 ●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPCompare.java 944 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPCompareOptions.java 36 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPDelete.java 745 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPDeleteOptions.java 60 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPModify.java 1085 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPModifyOptions.java 61 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPPasswordModify.java 729 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPSearch.java 1647 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPSearchOptions.java 238 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPToolOptions.java 155 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPToolUtils.java 302 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/tools/LDIFDiff.java 918 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/tools/LDIFModify.java 614 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/tools/LDIFSearch.java 782 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/tools/StopDS.java 2 ●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/types/BackupInfo.java 6 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/types/NullOutputStream.java 10 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/util/Base64.java 752 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/util/LDIFReader.java 5 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/util/LDIFWriter.java 1 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/TestCaseUtils.java 36 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/api/PasswordValidatorTestCase.java 21 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/authorization/dseecompat/AciTestCase.java 104 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/authorization/dseecompat/AciTests.java 53 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/authorization/dseecompat/ReferencesTestCase.java 4 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/authorization/dseecompat/TargetControlTestCase.java 5 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/backends/LDIFBackendTestCase.java 14 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/backends/SchemaBackendTestCase.java 7 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/controls/MatchedValuesControlTest.java 4 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/controls/PersistentSearchControlTest.java 6 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/core/AddOperationTestCase.java 15 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/core/BindOperationTestCase.java 28 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/core/DeleteOperationTestCase.java 9 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/core/GroupManagerTestCase.java 9 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/core/ModifyOperationTestCase.java 21 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/core/PasswordPolicyTestCase.java 47 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/core/RejectUnauthReqTests.java 46 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/core/SearchOperationTestCase.java 9 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/core/SubentryManagerTestCase.java 11 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/core/TestModifyDNOperation.java 7 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/extensions/AnonymousSASLMechanismHandlerTestCase.java 9 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/extensions/CRAMMD5SASLMechanismHandlerTestCase.java 25 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/extensions/DigestMD5SASLMechanismHandlerTestCase.java 39 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/extensions/ExternalSASLMechanismHandlerTestCase.java 42 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/extensions/FingerprintCertificateMapperTestCase.java 33 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/extensions/PasswordModifyExtendedOperationTestCase.java 99 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/extensions/PlainSASLMechanismHandlerTestCase.java 11 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/extensions/StartTLSExtendedOperationTestCase.java 26 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/extensions/SubjectAttributeToUserAttributeCertificateMapperTestCase.java 48 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/extensions/SubjectDNToUserAttributeCertificateMapperTestCase.java 38 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/extensions/TraditionalWorkQueueTestCase.java 5 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/extensions/UserDefinedVirtualAttributeProviderTestCase.java 15 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/plugins/SevenBitCleanPluginTestCase.java 36 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/protocols/ldap/LDAPBinaryOptionTestCase.java 25 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/protocols/ldap/TestAddRequestProtocolOp.java 6 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/replication/ChangeNumberControlPluginTestCase.java 186 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/replication/InitOnLineTest.java 5 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/replication/plugin/HistoricalTest.java 5 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/replication/plugin/ReplicationRepairControlTest.java 15 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/replication/server/MonitorTest.java 6 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/schema/CollationMatchingRuleTest.java 6 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/tasks/AllowedTaskTestCase.java 11 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/tasks/LockdownModeTaskTestCase.java 28 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/tools/ArgumentParserToolsTestCase.java 48 ●●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/types/EntrySchemaCheckingTestCase.java 47 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/types/PrivilegeTestCase.java 18 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/types/SearchFilterTests.java 4 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/util/TestBase64.java 202 ●●●●● diff | view | raw | blame | history