mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
30.50.2013 0a362c93159c92384f9b169e35c43987db54194f
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Tuesday, April 30, 2013 09:50 +0200
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Tuesday, April 30, 2013 09:50 +0200
commit0a362c93159c92384f9b169e35c43987db54194f
tree 2d76ccecc0f3cfbe8837d3b014ee204b027312c4 tree | zip | gz
parent a24641d3bb529d84aaaa1b5deb4c15f4efd1d403 view | diff
Made code more generic: Used Map instead of HashMap in method signatures.

AttrHistoricalMultiple.java, AttrHistoricalSingle.java:
Changed comments to javadocs.
Fixed condition checking.
Inlined local variables and used the field instead.
Replaced use of Boolean with boolean.

We were looking at this code with Ludo and thought replacing the List with a Map had to be done in conjunction with breaking up AttrValueHistorical class to reduce memory usage (removing stroing unnecessary references).
The value field should be used as the key of the Map, and the value of the Map should contain an object with a reference to a ChangeNumber and a boolean indicating whether it is an update or a delete (Since they are mutually exclusive).
2 files modified
64 ■■■■ changed files
opendj-sdk/opends/src/server/org/opends/server/replication/plugin/AttrHistoricalMultiple.java 45 ●●●● diff | view | raw | blame | history
opendj-sdk/opends/src/server/org/opends/server/replication/plugin/AttrHistoricalSingle.java 19 ●●●●● diff | view | raw | blame | history