mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
14.30.2013 0a51f5fbeb5e99c52f1be8973ae656de34fab75f
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Wednesday, August 14, 2013 11:30 +0200
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Wednesday, August 14, 2013 11:30 +0200
commit0a51f5fbeb5e99c52f1be8973ae656de34fab75f
tree 3b5533561b09b71b2174a6df83c2e1e5a4828f0f tree | zip | gz
parent 8a1708af76d17b5f605c4615051ab1c9ddf1f9fe view | diff
OPENDJ-1116 Introduce abstraction for the changelog DB

Removed avoidable references to replicationServerDomain.getReplicationServer().
Code cleanups:
- collapsed if statements
- applied early exits
- Replaced useless use of StringBulders with string concatenations
- Removed useless parentheses


*ServerHandler.java:
Replaced calls to this.replicationServerDomain.getReplicationServer() with directly using this.replicationServer .

DataServerHandler.java:
Inlined local variables.
Removed useless catch.

ECLServerHandler.java:
Extracted method releaseIterator().

LightweightServerHandler.java:
Extracted method getLocalRSMonitorInstanceName().

ReplicationServerHandler.java
In isRemoteLDAPServer(), renamed parameter.


MessageHandler.java:
Extracted methods collectAllIteratorsWithChanges(), addIteratorIfNotEmpty(), releaseAllIterators().

ReplicationServerDomain.java
Renamed replicationServer to localReplicationServer.
In put(), renamed id to serverId + extracted method publishMessage().
In getChangelogIterator(), renamed parameter.
Extracted methods replyWithMonitorMsg(), replyWithUnroutableMsgType(), forwardMsgToAllServers(), replyWithUnreachablePeerMsg() from process().
Renamed stopDbHandlers() to shutdownDbHandlers().
Extracted isServerConnected() from getEligibleCN().



DbHandler.java, JEReplicationIterator.java:
Renamed parameter.
8 files modified
1112 ■■■■ changed files
opends/src/server/org/opends/server/replication/server/DataServerHandler.java 155 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ECLServerHandler.java 58 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/LightweightServerHandler.java 43 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/MessageHandler.java 143 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ReplicationServerDomain.java 536 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ReplicationServerHandler.java 151 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/changelog/je/DbHandler.java 13 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/changelog/je/JEReplicationIterator.java 13 ●●●● diff | view | raw | blame | history