mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
09.32.2013 15cee34e0d9b3d576c7278a5a7bdf21d6c2d7900
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Friday, August 9, 2013 11:32 +0200
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Friday, August 9, 2013 11:32 +0200
commit15cee34e0d9b3d576c7278a5a7bdf21d6c2d7900
tree f23226e81135d523a7aebd2ac7d1238c30221a90 tree | zip | gz
parent a04520887d0c7bd1c1cbe4511c4e17bbe5eb6278 view | diff
ExternalChangeLogTest.java:
Removed 400 lines of code by:
- Used TestCaseUtils.findFreePort().
- Removed try / catch / fail test anti pattern + let the exceptions go up the stack.
- Extracted methods stop(), assertEntries().
- Used interfaces instead of concrete classes.
- Converting comments to javadocs.
- Removed useless parameters in readLastCookie().
- Removed unnecessary creations of new String objects.
- Removed unnecessary calls to toString() in string concatenations.
- Reduced variable scopes.
- Put code on one line to ease reading.
1 files modified
924 ■■■■■ changed files
opendj-sdk/opends/tests/unit-tests-testng/src/server/org/opends/server/replication/ExternalChangeLogTest.java 924 ●●●●● diff | view | raw | blame | history