mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noël Rouvignac
01.02.2015 1ab173bb3536182a1eb40f49e59c44bc030d649b
refs
author Jean-Noël Rouvignac <jean-noel.rouvignac@forgerock.com>
Thursday, October 1, 2015 11:02 +0200
committer Jean-Noël Rouvignac <jean-noel.rouvignac@forgerock.com>
Tuesday, October 6, 2015 10:08 +0200
commit1ab173bb3536182a1eb40f49e59c44bc030d649b
tree bd519459d565215075773193b028b880384ff805 tree | zip | gz
parent f8e01cac63c2468e082a77889c3a7b354eb14c8e view | diff
bugfix: dsconfig on loggers trigger thread leaks

When applying configuration changes, the code was leaking AsynchronousTextWriters and ParallelTextWriters.
These two classes create threads in their constructors.
Leaking such objects end up creating way too many threads which in turn have a bad effect on the whole system.

Text*LogPublisher.java:
In applyConfigurationChange(), make sure:
- no [Asynchronous|Parallel]TextWriters are leaked
- the logic applying the changes only creates new objects when necessary
Added methods useAsyncWriter(), hasAsyncConfigChanged(), hasParallelConfigChanged().
5 files modified
268 ■■■■ changed files
opendj-server-legacy/src/main/java/org/opends/server/loggers/TextAccessLogPublisher.java 87 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/loggers/TextAuditLogPublisher.java 27 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/loggers/TextDebugLogPublisher.java 27 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/loggers/TextErrorLogPublisher.java 30 ●●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/loggers/TextHTTPAccessLogPublisher.java 97 ●●●● diff | view | raw | blame | history