mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
19.04.2014 2c977273201717e109f7373cd60979cdc435f6e9
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Friday, September 19, 2014 18:04 +0200
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Friday, September 19, 2014 18:04 +0200
commit2c977273201717e109f7373cd60979cdc435f6e9
tree f32b0f6374c139ba228eb13d272783fb679963af tree | zip | gz
parent 0e63575f95dafe1cdb67fb1cc3814ac97e51596e view | diff
Removed useless getChangeNumber() and setChangeNumber methods from *Operation interfaces.
These methods are useless because setChangeNumber() is never set inside production code, so changeNumber is always equal to -1 for all the update operations. In addition it is very unlikely the ChangeNumberIndexer could have computed the changeNumber before a results are sent to a persistent search.


AddOperation*.java, DeleteOperation*.java, ModifyDNOperation*.java, ModifyOperation*.java:
Removed changeNumber fields + getters and setters.
Code cleanup.

PersistentSearch.java:
In process*() public methods, removed the long changeNumber attributes.
Removed baseDN, scope and filter fields, and retrieve them directly from the SearchOperation.
Extracted methods isInScope(), isInScopeForModify(), isAnyInScopeForModify(), matchesFilter(), anyMatchesFilter(), sendEntry(), createControls().
to factorize duplicated code.

LocalBackend*Operation.java:
Consequence of the changes to PersistentSearch.process*() methods.
Code cleanup.

ECLServerWriter.java:
In publish(), consequence of the change to PersistentSearch.processAdd().
In doIt(), simplified code by extracting takeECLUpdate() method.
21 files modified
2648 ■■■■ changed files
opendj3-server-dev/src/server/org/opends/server/core/AddOperation.java 49 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/AddOperationBasis.java 143 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/AddOperationWrapper.java 83 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/DeleteOperation.java 28 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/DeleteOperationBasis.java 71 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/DeleteOperationWrapper.java 44 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/ModifyDNOperation.java 56 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/ModifyDNOperationBasis.java 147 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/ModifyDNOperationWrapper.java 88 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/ModifyOperation.java 40 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/ModifyOperationBasis.java 100 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/ModifyOperationWrapper.java 63 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/PersistentSearch.java 487 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/replication/server/ECLServerWriter.java 53 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/workflowelement/localbackend/LocalBackendAddOperation.java 177 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/workflowelement/localbackend/LocalBackendDeleteOperation.java 86 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/workflowelement/localbackend/LocalBackendModifyDNOperation.java 122 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/workflowelement/localbackend/LocalBackendModifyOperation.java 346 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/core/AddOperationTestCase.java 339 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/core/DeleteOperationTestCase.java 49 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/core/ModifyOperationTestCase.java 77 ●●●●● diff | view | raw | blame | history