mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
30.50.2013 369d439a72b19cd7f95aaae555b180cd4f0eaedd
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Tuesday, April 30, 2013 09:50 +0200
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Tuesday, April 30, 2013 09:50 +0200
commit369d439a72b19cd7f95aaae555b180cd4f0eaedd
tree 0a2ddbc4dcfd18508f507971790a63faa38a57a9 tree | zip | gz
parent da7eec061560d498abfb2eb261f59ca41e84a4bd view | diff
Made code more generic: Used Map instead of HashMap in method signatures.

AttrHistoricalMultiple.java, AttrHistoricalSingle.java:
Changed comments to javadocs.
Fixed condition checking.
Inlined local variables and used the field instead.
Replaced use of Boolean with boolean.

We were looking at this code with Ludo and thought replacing the List with a Map had to be done in conjunction with breaking up AttrValueHistorical class to reduce memory usage (removing stroing unnecessary references).
The value field should be used as the key of the Map, and the value of the Map should contain an object with a reference to a ChangeNumber and a boolean indicating whether it is an update or a delete (Since they are mutually exclusive).
2 files modified
64 ■■■■ changed files
opends/src/server/org/opends/server/replication/plugin/AttrHistoricalMultiple.java 45 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/plugin/AttrHistoricalSingle.java 19 ●●●●● diff | view | raw | blame | history