mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
26.51.2013 403f2977dffbdb72660538effbfdd6ea9473af3a
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Monday, August 26, 2013 15:51 +0200
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Monday, August 26, 2013 15:51 +0200
commit403f2977dffbdb72660538effbfdd6ea9473af3a
tree a856c98f7d22f395259f1e91247a5461f733b174 tree | zip | gz
parent 00de072c846f7308623ff5b47a3f79cf2b79b34b view | diff
Found problems in the replication ECL code.
Also made the code more explicit.


DraftCNBDHandler.java, ChangelogDB.java:
Renamed firstkey and lastkey to firstDraftCN and lastDraftCN + renamed getters too.
In clear() added very a important comment about unreliable method call + renamed currentkey local variable to currentDraftCN + used final keyword.

ECLServerHandler.java:
Renamed all the *Key local variables to *DraftCN where possible.

ReplicationServer.java:
Renamed field replicationServers to replicationServerUrls.
Changed excludedBaseDNs from Collection to Set.
Did some renaming here and there.
Extracted method contains().
In getECLDraftCNLimits(), used primitive variables. There was some code that worked by chance more than by design: see in the old code "if (newestDate == 0L)"

DraftCNDbHandlerTest.java:
Renamed firstkey to firstDraftCN.
5 files modified
193 ■■■■ changed files
opends/src/server/org/opends/server/replication/server/ECLServerHandler.java 11 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ReplicationServer.java 106 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/changelog/api/ChangelogDB.java 4 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/changelog/je/DraftCNDbHandler.java 52 ●●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/server/changelog/je/DraftCNDbHandlerTest.java 20 ●●●● diff | view | raw | blame | history