mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Matthew Swift
19.36.2013 41bef7c0b619c7bc925326451a56071b5736580a
refs
author Matthew Swift <matthew.swift@forgerock.com>
Wednesday, June 19, 2013 10:36 +0200
committer Matthew Swift <matthew.swift@forgerock.com>
Wednesday, June 19, 2013 10:36 +0200
commit41bef7c0b619c7bc925326451a56071b5736580a
tree c117a94c82b61b503e997579640fcae308aba450 tree | zip | gz
parent 22cd9327680765b15fa89b1985bf375b9a0a3e3b view | diff
Fix OPENDJ-986: Exception when reading messages from Replication server RS

* make protocol versioning the responsibility of the ProtocolSession object. Previously, it was split between various classes making it very confusing and risk-prone. Now only one class (TLSSocketSession) "owns" the protocol version
* removed ReplicationMsg.getBytes() and require that all message impls implement ReplicationMsg.getBytes(short protocolVersion). Messages which have never evolved since the first protocol version can simply ignore the passed in protocol version parameter
* simplified the handshake process, ensuring that we always set the protocol version once the handshake has completed. Part of this change was to remove the protocol version from the start message constructors, since it is implied during encoding (this removes some ambiguity in these classes)
* many other minor code clean ups and bug fixes.
47 files modified
1152 ■■■■■ changed files
opends/src/server/org/opends/server/replication/protocol/AckMsg.java 2 ●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/ChangeStatusMsg.java 3 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/ChangeTimeHeartbeatMsg.java 11 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/DoneMsg.java 3 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/ECLUpdateMsg.java 7 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/EntryMsg.java 10 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/ErrorMsg.java 10 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/HeartbeatMsg.java 3 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/InitializeRcvAckMsg.java 3 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/InitializeRequestMsg.java 10 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/InitializeTargetMsg.java 10 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/LDAPUpdateMsg.java 15 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/MonitorMsg.java 9 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/MonitorRequestMsg.java 3 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/ProtocolSession.java 36 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/ProtocolVersion.java 2 ●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/ReplServerStartDSMsg.java 22 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/ReplServerStartMsg.java 23 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/ReplicationMsg.java 263 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/ResetGenerationIdMsg.java 3 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/ServerStartECLMsg.java 12 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/ServerStartMsg.java 11 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/StartECLSessionMsg.java 2 ●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/StartMsg.java 9 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/StartSessionMsg.java 64 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/StopMsg.java 3 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/TLSSocketSession.java 25 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/TopologyMsg.java 10 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/UpdateMsg.java 41 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/WindowMsg.java 3 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/protocol/WindowProbeMsg.java 3 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/DataServerHandler.java 83 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ECLServerHandler.java 78 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ECLServerWriter.java 7 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/NotAssuredUpdateMsg.java 9 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ReplicationServer.java 3 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ReplicationServerDomain.java 18 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ReplicationServerHandler.java 73 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ServerHandler.java 95 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ServerWriter.java 7 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/service/ReplicationBroker.java 7 ●●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/plugin/AssuredReplicationPluginTest.java 2 ●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/plugin/ComputeBestServerTest.java 46 ●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/protocol/ProtocolCompatibilityTest.java 24 ●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/protocol/SynchronizationMsgTest.java 65 ●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/server/AssuredReplicationServerTest.java 2 ●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/server/ReplicationServerTest.java 2 ●●● diff | view | raw | blame | history