mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
26.41.2013 539de41bd4f662192967855435c0e655188588c9
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Monday, August 26, 2013 10:41 +0200
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Monday, August 26, 2013 10:41 +0200
commit539de41bd4f662192967855435c0e655188588c9
tree 69a1496c42e9f73067d5571616bbe5894afb39f0 tree | zip | gz
parent f19e7551c198f0dde65079978dbec5310c010c78 view | diff
OPENDJ-1116 Introduce abstraction for the changelog DB

Introduced interfaces ChangelogDB and ChangelogDBIterator to remove direct dependencies to org.opends.server.replication.server.changelog.je .
The interfaces remain similar to the old classes DraftCNDbHandler and DraftCNDbIterator, but:
- I plan to introduce more changes to rework a bit these interfaces
- They reduce the number of accessible methods for client code


ChangelogDB.java: ADDED
Renamed getValue() to getPreviousCookie().

ChangelogDBIterator.java: ADDED
Renamed releaseCursor() to close().


*.java:
Consequence of the use of the new interfaces.
Renamed instance variables, local variables and method parameters to accommodate the new classes.
Also renamed variables and methods to better explicit their role.
Also reworked javadocs and comments.


ReplicationServer.java:
Extracted method contains().
In getEligibleCN(), reworked the code to avoid computing debug information if debug is off.
Renamed local variables.
Removed useless comments.

DraftCNDB.java:
Removed unused instance member ReplicationServer.

DraftCNDbHandler.java:
Now implements ChangelogDB.
Consequence of change to DraftCNDB.
Extracted method debugException().
Removed releaseReadCursor() (Replaced by StaticUtils.close()).

DraftCNDbIterator.java:
Now implements ChangelogDBIterator.

TestCaseUtils.java:
In deleteDirectory(), added a null check and an exists check.

DbHandlerTest.java, DraftCNDbHandlerTest.java:
Extracted method createCleanDir().
Removed now useless checks before calling TestCaseUtils.deleteDirectory().
Called StaticUtils.close().
Extracted method assertIteratorReadsInOrder().
9 files modified
2 files added
935 ■■■■ changed files
opendj-sdk/opends/src/server/org/opends/server/replication/server/ECLServerHandler.java 68 ●●●● diff | view | raw | blame | history
opendj-sdk/opends/src/server/org/opends/server/replication/server/ReplicationServer.java 168 ●●●● diff | view | raw | blame | history
opendj-sdk/opends/src/server/org/opends/server/replication/server/changelog/api/ChangelogDB.java 150 ●●●●● diff | view | raw | blame | history
opendj-sdk/opends/src/server/org/opends/server/replication/server/changelog/api/ChangelogDBIterator.java 78 ●●●●● diff | view | raw | blame | history
opendj-sdk/opends/src/server/org/opends/server/replication/server/changelog/je/DraftCNDB.java 7 ●●●● diff | view | raw | blame | history
opendj-sdk/opends/src/server/org/opends/server/replication/server/changelog/je/DraftCNDbHandler.java 203 ●●●●● diff | view | raw | blame | history
opendj-sdk/opends/src/server/org/opends/server/replication/server/changelog/je/DraftCNDbIterator.java 40 ●●●●● diff | view | raw | blame | history
opendj-sdk/opends/tests/unit-tests-testng/src/server/org/opends/server/TestCaseUtils.java 39 ●●●●● diff | view | raw | blame | history
opendj-sdk/opends/tests/unit-tests-testng/src/server/org/opends/server/replication/ExternalChangeLogTest.java 4 ●●●● diff | view | raw | blame | history
opendj-sdk/opends/tests/unit-tests-testng/src/server/org/opends/server/replication/server/changelog/je/DbHandlerTest.java 46 ●●●●● diff | view | raw | blame | history
opendj-sdk/opends/tests/unit-tests-testng/src/server/org/opends/server/replication/server/changelog/je/DraftCNDbHandlerTest.java 132 ●●●●● diff | view | raw | blame | history