mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Nicolas Capponi
08.12.2013 56d277d47e01e39145c0371f36b238121a1cf237
refs
author Nicolas Capponi <nicolas.capponi@forgerock.com>
Tuesday, October 8, 2013 18:12 +0200
committer Nicolas Capponi <nicolas.capponi@forgerock.com>
Tuesday, October 8, 2013 18:12 +0200
commit56d277d47e01e39145c0371f36b238121a1cf237
tree 32d311793c8d7c6c14e3ec579910159628c70524 tree | zip | gz
parent 9e7f24ceaf81315e49decb9ebb7aed54c25b5dee view | diff
OPENDJ-346 Consider using java.util.ServiceLoader for loading extensions and requesting transport implementations

Fixed an issue in StaticUtils#getProvider : passing a null class loader to ServiceLoader#load(Class<T>, ClassLoader) has unexpected effect,
ie it is not throwing a NPE and has not the same behavior that ServiceLoader#load(Class<T>).

Now code explicitely checks for null class loader and use the appropriate load method.

As a consequence :
* Reverted in all tests of opendj-ldap-sdk the use of a specific LDAPOption to provide a specific class loader, as it is not necessary any more with the fix.
* Removed utility methods in TestCaseUtils class to ease the use of custom class loader, they're not needed anymore
7 files modified
242 ■■■■■ changed files
opendj-sdk/opendj3/opendj-ldap-sdk/src/main/java/com/forgerock/opendj/util/StaticUtils.java 16 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj3/opendj-ldap-sdk/src/test/java/com/forgerock/opendj/ldap/GrizzlyLDAPConnectionTestCase.java 6 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/ConnectionFactoryTestCase.java 63 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/LDAPConnectionFactoryTestCase.java 43 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/LDAPListenerTestCase.java 90 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/LDAPServer.java 2 ●●● diff | view | raw | blame | history
opendj-sdk/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/TestCaseUtils.java 22 ●●●●● diff | view | raw | blame | history