mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
30.09.2014 5bd8fa4ffc02593312ad3fca9651730b060c56e3
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Thursday, October 30, 2014 12:09 +0100
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Thursday, October 30, 2014 12:09 +0100
commit5bd8fa4ffc02593312ad3fca9651730b060c56e3
tree 9252896e43c5f42b9119c781b0f56c40d38b7efe tree | zip | gz
parent 4e23ba2d62363baf5bd5a0d2b7f474e0a8d75d64 view | diff
OPENDJ-1613 (CR-5064) NullPointerException while searching on ch=changelog

The problem happens when doing a search in the change number changelog.
It only appears when there are two replicas under the same domain.
When creating the domain cursor, it is initialized from the content of the change number index DB. A replica cursor is created for each replica. The first replica cursor is initialized from the CSN coming from the change number index DB while the second replica cursor is initialized from the null CSN.
Under this circumstance, the second replica cursor is immediately added to the exhausted cursors of the domain cursor, and never gets out of it despite its replica DB being not empty.
The reason is because next() is never called on the the underlying ReplServerDBCursor.


JEReplicaDBCursor.java:
In next(), test whether the cursor has already been initialized (rather than verifying if a previous record exists) in order to verify if this is the first time next() is called.
Removed currentChange field which duplicates the content of ReplServerDBCursor.currentRecord .
Better handled the cursor closed state in all the methods.-5064) NullPointerException while searching on ch=changelog

The problem happens when doing a search in the change number changelog.
It only appears when there are two replicas under the same domain.
When creating the domain cursor, it is initialized from the content of the change number index DB. A replica cursor is created for each replica. The first replica cursor is initialized from the CSN coming from the change number index DB while the second replica cursor is initialized from the null CSN.
Under this circumstance, the second replica cursor is immediately added to the exhausted cursors of the domain cursor, and never gets out of it despite its replica DB being not empty.
The reason is because next() is never called on the the underlying ReplServerDBCursor.


JEReplicaDBCursor.java:
In next(), test whether the cursor has already been initialized (rather than verifying if a previous record exists) in order to verify if this is the first time next() is called.
Removed currentChange field which duplicates the content of ReplServerDBCursor.currentRecord .
Better handled the cursor closed state in all the methods.
1 files modified
38 ■■■■ changed files
opendj3-server-dev/src/server/org/opends/server/replication/server/changelog/je/JEReplicaDBCursor.java 38 ●●●● diff | view | raw | blame | history