mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
28.57.2014 667d7253a3873ed64dafbffe39d8a84a298c1fdc
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Monday, April 28, 2014 12:57 +0200
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Monday, April 28, 2014 12:57 +0200
commit667d7253a3873ed64dafbffe39d8a84a298c1fdc
tree 5b0450898b26bb1f2693ed97fd88e73e1936f84d tree | zip | gz
parent 56a730cb4c5473349dda9fecde648dd406ed6f35 view | diff
Code cleanup:
- Increased MessageHandler encapsulation.
- Removed ServerHandler.closeSession() because it is adding unnecessary complexity in understanding calling sites.


MessageHandler.java:
Reduced class visibility to package private. Did the same for a few methods.
Made several fields private for better encapsulation.
Renamed getDomain() to setDomain().
In setBaseDNAndDomain(), changed the code to always set the ReplicationServerDomain, so it can never be null. Avoids any NPE + allows to remove null checks.

DataServerHandler.java:
In receiveNewStatus(), consequence of the change to MessageHandler: removed null check on replicationServerDomain.

ECLServerHandler.java, ReplicationServerHandler.java:
Consequence of the change to MessageHandler: removed null check on replicationServerDomain.

ServerHandler.java:
Consequence of the change to MessageHandler: removed null check on replicationServerDomain.
Removed closeSession() because it is adding unnecessary complexity in understanding calling sites.
In abortStart(), inlined the code of closeSession().
Removed the unneeded overriding methods for getInCount() and getOutCount().

ReplicationServer.java:
Consequence of removing ServerHandler.closeSession().
6 files modified
173 ■■■■■ changed files
opends/src/server/org/opends/server/replication/server/DataServerHandler.java 5 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ECLServerHandler.java 3 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/MessageHandler.java 46 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ReplicationServer.java 9 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ReplicationServerHandler.java 3 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ServerHandler.java 107 ●●●● diff | view | raw | blame | history