mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
03.21.2013 6b5455aba72709fb4d3841acfd8241508a6f620e
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Thursday, October 3, 2013 11:21 +0200
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Thursday, October 3, 2013 11:21 +0200
commit6b5455aba72709fb4d3841acfd8241508a6f620e
tree 4b2973375ca2f281dc03dedca18771339de36680 tree | zip | gz
parent 506a85bd75116d11042bc20f0938083aa32ec58c view | diff
Maybe the end of endless pain and suffering on the Continuous Integration front - take 2.

In ExternalChangeLogTest.ECLReplicationServerFullTest(), debugging somewhat allows to reproduce the problem. The sequence of events is... interesting.
In ECLAfterChangelogTrim(), the last published DeleteMsg might not even have even been received on the other side when the test ends (i.e. ServerReader.run() might never have called/completed calling Session.receive()), hence clearing the changelogDB cannot clear this yet to be received message!
Looking closely at this test, I cannot see any reason to publish this DeleteMsg, so I removed this code. I also took the opportunity to get rid of what look like a useless 1s sleep.

ExternalChangeLogTest.java:
In ECLReplicationServerFullTest(), removed sending a useless DeleteMsg that changes nothing to the test result + removed a useless 1s sleep (Yay!) + removed the call to clearChangelogDB() in the finally block (already called by a @AfterTest)
1 files modified
17 ■■■■ changed files
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/server/ExternalChangeLogTest.java 17 ●●●● diff | view | raw | blame | history