mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
27.30.2013 6bdd95c0dec614421fab261964ca8725293c0837
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Friday, September 27, 2013 14:30 +0200
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Friday, September 27, 2013 14:30 +0200
commit6bdd95c0dec614421fab261964ca8725293c0837
tree 93376055a00795e8d23be3f551ab41bc81079706 tree | zip | gz
parent 8466335ecf8a4d3f5b63a9da2572f1ec81981440 view | diff
Fixed the failing nightly test GenerationIdTest.testSingleRS().


GenerationIdTest.java:
In testSingleRS(), called again ReplicationServer.remove() instead of ReplicationServerTestCase.remove() because the test does not expect the DB to be wiped out.
Changed all protected keywords to private since it is never subclassed.
Renamed testEntriesInDb() to countUpdatedEntriesInDb().
Removed useless try / catch and let the exceptions go up.
Replaced uses of assertTrue() with the appropriate assert* method.
Changed the return type of createAddMsg() to return the appropriate type.
Extracted method assertNoMessageReceivedBadGenId(), waitForStableGenerationId().

ReplicationTestCase.java:
In addTestEntriesToDB(), used varargs.
Removed outdated openReplicationSession().
Removed useless try / catch and let the exceptions go up.

ReplicationServerTest.java:
Extracted method sendAndReceiveDeleteMsg() and newServerState().
Used Arrays.asList().
3 files modified
735 ■■■■■ changed files
opendj-sdk/opends/tests/unit-tests-testng/src/server/org/opends/server/replication/GenerationIdTest.java 393 ●●●●● diff | view | raw | blame | history
opendj-sdk/opends/tests/unit-tests-testng/src/server/org/opends/server/replication/ReplicationTestCase.java 182 ●●●●● diff | view | raw | blame | history
opendj-sdk/opends/tests/unit-tests-testng/src/server/org/opends/server/replication/server/ReplicationServerTest.java 160 ●●●●● diff | view | raw | blame | history