Fix for 3844 : ReplicationDomain.publish can loose changes when called by several thread.

Some locking must be done between the Generation of the ChangeNumber
and the call to broker.publish() because the broker does not do any
re-ordering and the ReplicationServer expect to receive the Changes
in the order defined by the ChangeNumber