mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noël Rouvignac
01.02.2015 7166491c42d43a48beac42bea796916019aee89e
refs
author Jean-Noël Rouvignac <jean-noel.rouvignac@forgerock.com>
Thursday, October 1, 2015 11:02 +0200
committer Jean-Noël Rouvignac <jean-noel.rouvignac@forgerock.com>
Tuesday, October 6, 2015 10:08 +0200
commit7166491c42d43a48beac42bea796916019aee89e
tree b24a6e3027816ddf42f4c097342b883af9e17d64 tree | zip | gz
parent ac8ab1da5e95660b38ecf606bc079b7786a86c7d view | diff
bugfix: dsconfig on loggers trigger thread leaks

When applying configuration changes, the code was leaking AsynchronousTextWriters and ParallelTextWriters.
These two classes create threads in their constructors.
Leaking such objects end up creating way too many threads which in turn have a bad effect on the whole system.

Text*LogPublisher.java:
In applyConfigurationChange(), make sure:
- no [Asynchronous|Parallel]TextWriters are leaked
- the logic applying the changes only creates new objects when necessary
Added methods useAsyncWriter(), hasAsyncConfigChanged(), hasParallelConfigChanged().
5 files modified
268 ■■■■ changed files
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/loggers/TextAccessLogPublisher.java 87 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/loggers/TextAuditLogPublisher.java 27 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/loggers/TextDebugLogPublisher.java 27 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/loggers/TextErrorLogPublisher.java 30 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/loggers/TextHTTPAccessLogPublisher.java 97 ●●●● diff | view | raw | blame | history