mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Gaetan Boismal
08.59.2016 88496c3a54b4c6e969cb0dce5cf67e5da6846740
refs
author Gaetan Boismal <gaetan.boismal@forgerock.com>
Tuesday, March 8, 2016 14:59 +0100
committer Gaetan Boismal <gaetan.boismal@forgerock.com>
Monday, October 31, 2016 14:59 +0100
commit88496c3a54b4c6e969cb0dce5cf67e5da6846740
tree f2b8d090e63a815cba515f8f477fc08d8b66f58e tree | zip | gz
parent 73394f670965893f1d728f7be6f326e0f696e73f view | diff
OPENDJ-2772 Code cleanup

* Improve code readability
* Rename local variables (like parameters)
* Factorize duplicated pieces of code across tools in Utils
* arguments parsing
* reading filters from string or file
* reading controls
* print messages
* Create LDAPToolArgumentParser to have a fluent way to build
argument parser and to mutualize argument parsing code generation for
ldap* tools.
* Create LDAPToolException class to handle error which may occur
during tool exection. This class manages return code and localizable
error message and allow code factorization in Utils.

* Mutualize generation code of the following arguments:
* -f, --fileName
* -S, --scriptFriendly
* --showUsage argument generation in make-ldif
* -J, --control

* MakeLDIFInputStream.java
* Remove unused templateFile field
* Inline generatorThread field

* Other little cleanup actions
2 files added
19 files modified
2437 ■■■■ changed files
opendj-cli/src/main/java/com/forgerock/opendj/cli/ArgumentConstants.java 6 ●●●● diff | view | raw | blame | history
opendj-cli/src/main/java/com/forgerock/opendj/cli/CommonArguments.java 14 ●●●●● diff | view | raw | blame | history
opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/AddRate.java 13 ●●●● diff | view | raw | blame | history
opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/AuthRate.java 14 ●●●●● diff | view | raw | blame | history
opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDAPCompare.java 179 ●●●●● diff | view | raw | blame | history
opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDAPModify.java 305 ●●●●● diff | view | raw | blame | history
opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDAPPasswordModify.java 137 ●●●● diff | view | raw | blame | history
opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDAPSearch.java 575 ●●●●● diff | view | raw | blame | history
opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDAPToolArgumentParser.java 161 ●●●●● diff | view | raw | blame | history
opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDAPToolException.java 68 ●●●●● diff | view | raw | blame | history
opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDIFDiff.java 107 ●●●● diff | view | raw | blame | history
opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDIFModify.java 150 ●●●●● diff | view | raw | blame | history
opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDIFSearch.java 156 ●●●● diff | view | raw | blame | history
opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/MakeLDIF.java 15 ●●●● diff | view | raw | blame | history
opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/ModRate.java 14 ●●●●● diff | view | raw | blame | history
opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/SearchRate.java 14 ●●●●● diff | view | raw | blame | history
opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/Utils.java 479 ●●●●● diff | view | raw | blame | history
opendj-ldap-toolkit/src/main/resources/com/forgerock/opendj/ldap/tools/tools.properties 8 ●●●●● diff | view | raw | blame | history
opendj-ldap-toolkit/src/test/java/com/forgerock/opendj/ldap/tools/LDAPCompareITCase.java 4 ●●● diff | view | raw | blame | history
opendj-ldap-toolkit/src/test/java/com/forgerock/opendj/ldap/tools/LDAPSearchITCase.java 4 ●●● diff | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/tools/makeldif/MakeLDIFInputStream.java 14 ●●●● diff | view | raw | blame | history