mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
26.11.2014 98a5df3565beaa1999020a16fcb5338d13d5b50f
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Tuesday, August 26, 2014 10:11 +0200
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Tuesday, August 26, 2014 10:11 +0200
commit98a5df3565beaa1999020a16fcb5338d13d5b50f
tree e2c33f2bcccff1dfcb1aabea825059735e725f8c tree | zip | gz
parent 0440760ba5af5211e7da2a120d708f11079973c4 view | diff
Removed useless getChangeNumber() and setChangeNumber methods from *Operation interfaces.
These methods are useless because setChangeNumber() is never set inside production code, so changeNumber is always equal to -1 for all the update operations. In addition it is very unlikely the ChangeNumberIndexer could have computed the changeNumber before a results are sent to a persistent search.


AddOperation*.java, DeleteOperation*.java, ModifyDNOperation*.java, ModifyOperation*.java:
Removed changeNumber fields + getters and setters.
Code cleanup.

PersistentSearch.java:
In process*() public methods, removed the long changeNumber attributes.
Removed baseDN, scope and filter fields, and retrieve them directly from the SearchOperation.
Extracted methods isInScope(), isInScopeForModify(), isAnyInScopeForModify(), matchesFilter(), anyMatchesFilter(), sendEntry(), createControls().
to factorize duplicated code.

LocalBackend*Operation.java:
Consequence of the changes to PersistentSearch.process*() methods.
Code cleanup.

ECLServerWriter.java:
In publish(), consequence of the change to PersistentSearch.processAdd().
In doIt(), simplified code by extracting takeECLUpdate() method.
21 files modified
2836 ■■■■ changed files
opends/src/server/org/opends/server/core/AddOperation.java 50 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/core/AddOperationBasis.java 147 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/core/AddOperationWrapper.java 85 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/core/DeleteOperation.java 29 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/core/DeleteOperationBasis.java 73 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/core/DeleteOperationWrapper.java 46 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/core/ModifyDNOperation.java 57 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/core/ModifyDNOperationBasis.java 159 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/core/ModifyDNOperationWrapper.java 90 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/core/ModifyOperation.java 41 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/core/ModifyOperationBasis.java 107 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/core/ModifyOperationWrapper.java 65 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/core/PersistentSearch.java 512 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ECLServerWriter.java 53 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/workflowelement/localbackend/LocalBackendAddOperation.java 191 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/workflowelement/localbackend/LocalBackendDeleteOperation.java 103 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/workflowelement/localbackend/LocalBackendModifyDNOperation.java 136 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/workflowelement/localbackend/LocalBackendModifyOperation.java 402 ●●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/core/AddOperationTestCase.java 347 ●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/core/DeleteOperationTestCase.java 56 ●●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/core/ModifyOperationTestCase.java 87 ●●●●● diff | view | raw | blame | history