mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
12.15.2014 99d33a80f9ac8ee98c24e1bcce9deab8b9815bf2
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Friday, September 12, 2014 16:15 +0200
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Friday, September 12, 2014 16:15 +0200
commit99d33a80f9ac8ee98c24e1bcce9deab8b9815bf2
tree 3a1014a2f88e0e188bcf2e523b009fa475431196 tree | zip | gz
parent 601ed48764f5efc6cd76404d95120dfc3c40c263 view | diff
Code cleanup for password storage schemes.
Used AutoRefactor.
Reduced variable scopes.


PBKDF2PasswordStorageScheme.java:
Extracted methods getDigestBytes(), encodeAndMatch(),
Removed unnecessary use of StringBuilders.
In passwordMatches() and authPasswordMatches(), used String.indexOf().

PKCS5S2PasswordStorageScheme.java:
See general changes.

PKCS5S2PasswordStorageSchemeTestCase.java:
In getTestPasswords(), reused the super method and filtered entries.
Fix test failures with Java 6 due to limitation in JDK.
3 files modified
1 files added
708 ■■■■■ changed files
opendj-sdk/opendj3-server-dev/src/server/org/opends/server/extensions/PBKDF2PasswordStorageScheme.java 372 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj3-server-dev/src/server/org/opends/server/extensions/PKCS5S2PasswordStorageScheme.java 211 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/extensions/PBKDF2PasswordStorageSchemeTestCase.java 87 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/extensions/PKCS5S2PasswordStorageSchemeTestCase.java 38 ●●●●● diff | view | raw | blame | history