mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
09.10.2013 a2c3fde785f4dcab651ee75492a95d3f6c07a853
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Monday, December 9, 2013 17:10 +0100
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Monday, December 9, 2013 17:10 +0100
commita2c3fde785f4dcab651ee75492a95d3f6c07a853
tree 40e929c359d9da728f04774f32d5602e5e9bf43e tree | zip | gz
parent b62e247c8d24edb88a87ed30ba904035c0dad59d view | diff
OPENDJ-1106 fractional-replication: adding entry on a replica as DM should not exit with RC 50

Code review: Matthew Swift


Regression caused by the fix for OPENDJ-948 unauthorized disclosure of directory contents.
The code was looking for the entry matching the DN we are adding which obviously was null here.
Since it was null, the code went on to wrongly check the following conditions: op.isInternalOperation() || op.isSynchronizationOperation() || op.isInnerOperation().
The correct fix was to avoid calling AccessControlHandler.canDiscloseInformation() where it did not make sense at all, when there was no info to protect yet.


LocalBackend*Operation.java:
Do not call the setResultCodeAndMessageNoInfoDisclosure() when we fail to grab a lock, because this is not disclosing any sensitive information at that point.

LocalBackendAddOperation.java:
Do not call the setResultCodeAndMessageNoInfoDisclosure() when we fail to grab a lock, because this is not disclosing any sensitive information at that point.
In lockParent(), reversed the exception to make the code easier to read.

LocalBackendModifyDNOperation.java:
Do not call the setResultCodeAndMessageNoInfoDisclosure() when we fail to grab a lock, because this is not disclosing any sensitive information at that point.
In newDirectoryException(), removed the entryDN parameter since now this method is always called with a non null entry.


AciHandler.java:
Code cleanup
6 files modified
150 ■■■■ changed files
opends/src/server/org/opends/server/authorization/dseecompat/AciHandler.java 41 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/workflowelement/localbackend/LocalBackendAddOperation.java 68 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/workflowelement/localbackend/LocalBackendCompareOperation.java 6 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/workflowelement/localbackend/LocalBackendDeleteOperation.java 5 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/workflowelement/localbackend/LocalBackendModifyDNOperation.java 25 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/workflowelement/localbackend/LocalBackendModifyOperation.java 5 ●●●●● diff | view | raw | blame | history