mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
25.56.2014 a47912185abb46815cc3104f2187bf63c22bcf03
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Tuesday, November 25, 2014 11:56 +0100
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Tuesday, November 25, 2014 11:56 +0100
commita47912185abb46815cc3104f2187bf63c22bcf03
tree f965ed18b72ba168ff7dcad30550be876e7b4d77 tree | zip | gz
parent a771fcaf1dc80a6c7ea29bde04adba0179f420d8 view | diff
OPENDJ-1545 (CR-5399) Remove Workflow, NetworkGroups and related attempts at building a proxy

Got rid of WorkflowTopology which is a parallel hierarchy of the BaseDnRegistry and the Backends which is an anti pattern (See Parallel Inheritance Hierarchy anti pattern, even though here it is more composition than inheritance at play).

Got rid of most of the Workflow and NetworkGroup classes my moving the important code to LocalBackendWorkflowElement.
Only remain bits and pieces of the old workflow design. We will need to see what we do with them (WorkflowResultCode, LocalBackendWorkflowElement naming?).



org/opends/server/core/networkgroups: REMOVED package

NetworkGroup.java, NetworkGroupNamingContexts.java, Workflow.java, WorkflowTopology.java, RootDseWorkflowTopology.java, WorkflowTopologyNode.java, WorkflowTopologyTest.java: REMOVED unused now


LocalBackendWorkflowElement.java:
Changed initialize(String, Backend<?>), createAndRegister(String, Backend), remove(String) and deregisterLocalBackend(String) to accept a DN argument instead of String.
Changed getWorkflowElementID() into getBaseDN().
Moved RootDseWorkflowTopology.execute() and WorkflowTopologyNode.execute() into this class as executeOnRootDSE() and executeOnNonRootDSE() + dependent methods. WorkflowTopology.execute() has been inlined into the moved code.
Removed useless fields workflowElementTypeInfo and BACKEND_WORKFLOW_ELEMENT.

AbstractOperation.java:
Added public updateOperationErrMsgAndResCode().

*OperationBasis.java:
Used LocalBackendWorkflowElement.execute(Operation, DN).
Made updateOperationErrMsgAndResCode() public.
Fixed javadocs.

WorkflowResultCode.java:
Made several methods public to use them in LocalBackendWorkflowElement.

NetworkGroupTest.java:
Renamed to org.opends.server.workflowelement.localbackend.LocalBackendWorkflowElementTest.
Added testNonRootDseSubordinateNamingContext().
Removed several tests that do not make sense anymore after removing the NetworkGroup class.


RootDSEBackend.java:
In getRootDSE(), get the public naming context from the DirectoryServer rather than the NetworkGroup.
Removed getSubordinateNamingContexts().
Made getSubordinateBaseDNs() public.

DirectoryServer.java:
In createWorkflow(), create and register the LocalBackendWorkflowElement by using the baseDN instead of the backendId.
Removed references to the NetworkGroup and replaced them with references to the LocalBackendWorkflowElement where it made sense.
12 files modified
9 files deleted
1 files added
3936 ■■■■ changed files
opendj3-server-dev/src/server/org/opends/server/backends/RootDSEBackend.java 71 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/AddOperationBasis.java 41 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/BindOperationBasis.java 24 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/CompareOperationBasis.java 142 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/DeleteOperationBasis.java 38 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/DirectoryServer.java 19 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/ModifyDNOperationBasis.java 31 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/ModifyOperationBasis.java 38 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/RootDseWorkflowTopology.java 189 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/SearchOperationBasis.java 29 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/Workflow.java 67 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/WorkflowResultCode.java 10 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/WorkflowTopology.java 161 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/WorkflowTopologyNode.java 470 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/networkgroups/NetworkGroup.java 403 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/networkgroups/NetworkGroupNamingContexts.java 162 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/networkgroups/package-info.java 48 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/types/AbstractOperation.java 37 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/workflowelement/localbackend/LocalBackendWorkflowElement.java 400 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/core/WorkflowTopologyTest.java 845 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/core/networkgroups/NetworkGroupTest.java 430 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/workflowelement/localbackend/LocalBackendWorkflowElementTest.java 281 ●●●●● diff | view | raw | blame | history