Made code more encapsulated and more explicit.
Removed parameters obscuring the code.
ReplicationServerDomain.java:
Renamed getServers() to getServerIds().
MessageHandler.java:
In getDomain(), removed createIfNotExist which was always true in calling code + called ReplicationServer.waitConnections() here.
In getRcvMsgQueueSize(), used early exit.
ReplicationServer.java:
In getReplicationServerDomain() methods, removed the create parameter.
Also extracted the waitConnections() method and called it higher up in the call hierarchy.
Created initDomainGenerationID() and addServerIdToDomain() methods here from code in ReplicationDbEnv.java
In runConnect(), collapsed if statements.
*.java
Consequence of the changes to:
- ReplicationServerDomain.getServers()
- ReplicationServer.getReplicationServerDomain()
- ReplicationServer.initDomainGenerationID() and addServerIdToDomain()
GenerationIdTest.java:
Extracted method isDegradedDueToGenerationId().
InitOnLineTest.java:
Extracted method getConnectedDSServerIds().