mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noël Rouvignac
29.52.2015 aa5f5b7688d3f2b3567411b214fd1a9cbb7030b1
refs
author Jean-Noël Rouvignac <jean-noel.rouvignac@forgerock.com>
Thursday, October 29, 2015 09:52 +0100
committer Jean-Noël Rouvignac <jean-noel.rouvignac@forgerock.com>
Tuesday, November 3, 2015 17:49 +0100
commitaa5f5b7688d3f2b3567411b214fd1a9cbb7030b1
tree 842602fa4685e997e3839645ddba90516fc1a288 tree | zip | gz
parent 0364afd608de95af991df681c3f952467b7c67ad view | diff
OPENDJ-1802 Address review comments about "Make ByteStringBuilder methods"

TimeBasedMatchingRulesImpl.java, core.properties:
Used:
- byte instead of int for encoding second, minute, day and month.
- compact unsigned instead of int for encoding year.
Replaced all mentions of 'date' by 'day'.
Replaced ByteBuffer with ByteSequenceReader.

AbstractSubstringMatchingRuleImpl.java:
Used byte instead of int for encoding ASCII chars.
In evaluateEscapedChar(), changed return type from char to byte.
In evaluateEscapes(), extracted method evaluateEscapes0().

*.java:
Removed now useless uses of '& 0xFF'
5 files modified
307 ■■■■ changed files
opendj-sdk/opendj-core/src/main/java/org/forgerock/opendj/ldap/Base64.java 12 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/main/java/org/forgerock/opendj/ldap/ByteStringBuilder.java 64 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/main/java/org/forgerock/opendj/ldap/schema/AbstractSubstringMatchingRuleImpl.java 41 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/main/java/org/forgerock/opendj/ldap/schema/TimeBasedMatchingRulesImpl.java 182 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-core/src/main/resources/com/forgerock/opendj/ldap/core.properties 8 ●●●● diff | view | raw | blame | history