mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
03.21.2013 b7ee846dbdbdd5ea8550a1d207c26dc8b8fa3aa3
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Thursday, October 3, 2013 11:21 +0200
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Thursday, October 3, 2013 11:21 +0200
commitb7ee846dbdbdd5ea8550a1d207c26dc8b8fa3aa3
tree 3005570674bed0ffa3f9b187985c2bfabb967dc6 tree | zip | gz
parent 69420fa7cf98b53103c30f8959c1e65d21441da4 view | diff
Maybe the end of endless pain and suffering on the Continuous Integration front - take 2.

In ExternalChangeLogTest.ECLReplicationServerFullTest(), debugging somewhat allows to reproduce the problem. The sequence of events is... interesting.
In ECLAfterChangelogTrim(), the last published DeleteMsg might not even have even been received on the other side when the test ends (i.e. ServerReader.run() might never have called/completed calling Session.receive()), hence clearing the changelogDB cannot clear this yet to be received message!
Looking closely at this test, I cannot see any reason to publish this DeleteMsg, so I removed this code. I also took the opportunity to get rid of what look like a useless 1s sleep.

ExternalChangeLogTest.java:
In ECLReplicationServerFullTest(), removed sending a useless DeleteMsg that changes nothing to the test result + removed a useless 1s sleep (Yay!) + removed the call to clearChangelogDB() in the finally block (already called by a @AfterTest)
1 files modified
17 ■■■■ changed files
opendj-sdk/opends/tests/unit-tests-testng/src/server/org/opends/server/replication/server/ExternalChangeLogTest.java 17 ●●●● diff | view | raw | blame | history