mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
21.59.2014 c430f8b3da724d0a117eadd172b92179b9a0b5a9
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Friday, March 21, 2014 12:59 +0100
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Friday, March 21, 2014 12:59 +0100
commitc430f8b3da724d0a117eadd172b92179b9a0b5a9
tree 69fd4d5d6968b1d6ca1742e636485ecb057b396b tree | zip | gz
parent 1fb8ee5250a80eeb79392062effc77bed930c3f4 view | diff
OPENDJ-1368 (CR-3232) Remove AttributeValue

Adressed comments from post commit review for r10554.

Code review: Matthew Swift



JebFormat.java:
In entryIDFromDatabase(), extracted toLong() for reuse outside of this class.
In entryIDUndefinedSizeFromDatabase(), called entryIDFromDatabase().



VlVIndex.java:
Extracted methods getSortValuesSet(), getSearchKeyRange(), logSearchKeyResult(), put(), moveToNextSortValues() to factorize code.
In evaluate(), regrouped guard clauses.
In getSortValues(), regrouped if statements.
In decodeKey(), called JebFormat.toLong().

VlVKeyComparator.java:
In compare(), called JebFormat.toLong().
In compare(), removed AttributeType[] parameter, no longer needed.

SortValuesSet.java:
In binarySearch(), removed AttributeType[] parameter, no longer needed (consequence of the change to VlVKeyComparator.compare()).

TestVerifyJob.java:
Consequence of removing AttributeType[] parameter from a few methods.

VirtualAttributeProvider.java:
Added matchesEqualityAssertion().
Fixed javadocs to speak about assertion values.



AbstractAttribute.java:
Pulled hashCode() implementation here from VirtualAttribute.

Attribute.java, CollectiveVirtualAttribute.java:
Added matchesEqualityAssertion().
Fixed javadocs + parameter names to speak about assertion values.

AttributeBuilder.java:
Used SmallMap instead of LinkedHashMap.
Added matchesEqualityAssertion().
Fixed javadocs + parameter names to speak about assertion values.

SmallMap.java, SmallMapTest.java: ADDED

VirtualAttribute.java:
Added matchesEqualityAssertion().
Fixed javadocs + parameter names to speak about assertion values.
Pulled up hashCode() implementation.

SearchFilter.java:
In processEquality(), changed implementation and called Attribute.matchesEqualityAssertion().



AttributeValueIterable.java: REMOVED

ServerManagementContext.java, TestEntry.java:
Consequence of removing AttributeValueIterable.



AttributeIndex.java:
Used normalizeAssertionValue() instead of normalizeAttributeValue() where appropriate.

ModifyEntryTask.java, UserDN.java:
Fixed small typo.

SearchFilterTests.java:
Code cleanup.
1 files deleted
2 files added
18 files modified
1697 ■■■■ changed files
opendj3-server-dev/src/guitools/org/opends/guitools/controlpanel/task/ModifyEntryTask.java 5 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/admin/server/ServerManagementContext.java 14 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/api/VirtualAttributeProvider.java 39 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/authorization/dseecompat/UserDN.java 8 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/backends/jeb/AttributeIndex.java 24 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/backends/jeb/JebFormat.java 31 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/backends/jeb/SortValuesSet.java 14 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/backends/jeb/VLVIndex.java 449 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/backends/jeb/VLVKeyComparator.java 35 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/types/AbstractAttribute.java 23 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/types/Attribute.java 34 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/types/AttributeBuilder.java 67 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/types/AttributeValueIterable.java 198 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/types/CollectiveVirtualAttribute.java 19 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/types/SearchFilter.java 35 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/types/SmallMap.java 257 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/types/VirtualAttribute.java 41 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/backends/jeb/TestVerifyJob.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/types/SearchFilterTests.java 141 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/types/SmallMapTest.java 249 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/types/TestEntry.java 8 ●●●●● diff | view | raw | blame | history