OPENDJ-1368 (CR-3232) Remove AttributeValue
Adressed comments from post commit review for r10554.
Code review: Matthew Swift
JebFormat.java:
In entryIDFromDatabase(), extracted toLong() for reuse outside of this class.
In entryIDUndefinedSizeFromDatabase(), called entryIDFromDatabase().
VlVIndex.java:
Extracted methods getSortValuesSet(), getSearchKeyRange(), logSearchKeyResult(), put(), moveToNextSortValues() to factorize code.
In evaluate(), regrouped guard clauses.
In getSortValues(), regrouped if statements.
In decodeKey(), called JebFormat.toLong().
VlVKeyComparator.java:
In compare(), called JebFormat.toLong().
In compare(), removed AttributeType[] parameter, no longer needed.
SortValuesSet.java:
In binarySearch(), removed AttributeType[] parameter, no longer needed (consequence of the change to VlVKeyComparator.compare()).
TestVerifyJob.java:
Consequence of removing AttributeType[] parameter from a few methods.
VirtualAttributeProvider.java:
Added matchesEqualityAssertion().
Fixed javadocs to speak about assertion values.
AbstractAttribute.java:
Pulled hashCode() implementation here from VirtualAttribute.
Attribute.java, CollectiveVirtualAttribute.java:
Added matchesEqualityAssertion().
Fixed javadocs + parameter names to speak about assertion values.
AttributeBuilder.java:
Used SmallMap instead of LinkedHashMap.
Added matchesEqualityAssertion().
Fixed javadocs + parameter names to speak about assertion values.
SmallMap.java, SmallMapTest.java: ADDED
VirtualAttribute.java:
Added matchesEqualityAssertion().
Fixed javadocs + parameter names to speak about assertion values.
Pulled up hashCode() implementation.
SearchFilter.java:
In processEquality(), changed implementation and called Attribute.matchesEqualityAssertion().
AttributeValueIterable.java: REMOVED
ServerManagementContext.java, TestEntry.java:
Consequence of removing AttributeValueIterable.
AttributeIndex.java:
Used normalizeAssertionValue() instead of normalizeAttributeValue() where appropriate.
ModifyEntryTask.java, UserDN.java:
Fixed small typo.
SearchFilterTests.java:
Code cleanup.