mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
19.27.2013 c7077670daca3b689ed75e4bf71dad0483af8473
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Monday, August 19, 2013 15:27 +0200
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Monday, August 19, 2013 15:27 +0200
commitc7077670daca3b689ed75e4bf71dad0483af8473
tree bab15b664b6d473b1d1ae5fbbe854254e351b8a5 tree | zip | gz
parent d51eba690902925cd89024bef2800e2232123da6 view | diff
Avoided possible costly thread leaks in ReplicationServerDomain.



ReplicationServerDomain.java:
Used AtomicReference for statusAnalyzer and monitoringPublisher.
As a consequence:
- Changed update*(), start*() and stop*() methods.
- Removed isRunning*() methods.

MonitoringPublisher.java:
Extracted getMessage() to make error messages more conherent.

ServerReader.java:
In run(), removed redundant code by checking whether the message is a RoutableMsg.
Extracted method logException().
In ServerReader.run(), moved some code to ServerHandler.put().
Code cleanups:
- inlined useless local variables
- removed useless use of "this" before method calls.

DataServerHandler.java, ECLServerHandler.java, ReplicationServerHandler.java:
Extracted method createReplServerStartMsg().

ServerHandler.java:
Renamed process(WindowProbeMsg) to replyToWindowProbe().
Made some instance members private.
Moved createReplServerStartMsg here.
In put(), moved decAndCheckWindow() call here from ServerReader.run().

WindowProbeMsg.java:
Fixed javadocs + simplified code.
8 files modified
316 ■■■■■ changed files
opends/src/server/org/opends/server/replication/protocol/WindowProbeMsg.java 23 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/DataServerHandler.java 6 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ECLServerHandler.java 6 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/MonitoringPublisher.java 33 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ReplicationServerDomain.java 85 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ReplicationServerHandler.java 6 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ServerHandler.java 31 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ServerReader.java 126 ●●●●● diff | view | raw | blame | history