mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
03.59.2013 cbf6bfd149ce305652be0aac68d210778b5cbba6
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Thursday, October 3, 2013 13:59 +0200
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Thursday, October 3, 2013 13:59 +0200
commitcbf6bfd149ce305652be0aac68d210778b5cbba6
tree 883365b2ac15b46326f2448e51ff2fa20cdc0e90 tree | zip | gz
parent cf053cd07d77de5e04191c39c0a7a9d9dd376ad9 view | diff
ReplicationTestCase.java:
Change entryList and configEntryList from LinkedList to Set and renamed them to entriesToCleanup and configEntriesToCleanup.
Extracted method connect() and waitForSpecificMsg() + Changed the return type of the existing waitForSpecificMsg() methods.
In configureReplication(), added 2 String parameters + extracted method addSynchroServerEntry() and addConfigEntry().
Simplified code a lot.

*Test[Case].java:
Consequence of the changes to ReplicationTestCase.
Factorized code with ReplicationTestCase.
Various cleanups:
- used assertj
- used StaticUtils.close()
- made fields private
- used foreach
- used assertEquals() instead of assertTrue()
- removed try/catch/fail test anti pattern.
- let exceptions go up the stack

ProtocolWindowTest.java:
Extracted method searchNbMonitorEntries().
13 files modified
702 ■■■■■ changed files
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/ChangeNumberControlPluginTestCase.java 30 ●●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/GenerationIdTest.java 23 ●●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/InitOnLineTest.java 42 ●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/ProtocolWindowTest.java 75 ●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/ReSyncTest.java 31 ●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/ReplicationTestCase.java 340 ●●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/SchemaReplicationTest.java 62 ●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/StressTest.java 18 ●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/UpdateOperationTest.java 55 ●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/plugin/AssuredReplicationPluginTest.java 6 ●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/plugin/HistoricalTest.java 4 ●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/server/MonitorTest.java 10 ●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/server/ReplicationServerTest.java 6 ●●●● diff | view | raw | blame | history