mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
17.46.2013 cec016958f29b8849a1768e588e1d728d621af49
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Tuesday, September 17, 2013 10:46 +0200
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Tuesday, September 17, 2013 10:46 +0200
commitcec016958f29b8849a1768e588e1d728d621af49
tree ad84d0bb7d9b5c8ef9530f83c566854583ea18e1 tree | zip | gz
parent 74328205a692a025fbf44a6af9c9f1f456ef34df view | diff
OPENDJ-1116 Introduce abstraction for the changelog DB

Fixed nightly test org.opends.server.replication.server.ExternalChangeLogTest#ECLReplicationServerFullTest14 broken by r9505.

r9505 allowed code to throw ChangelogException and removed several useless catch(), in particular, a catch was removed from DraftCNDbHandler's methods getPreviousCookie(), getCSN(), getBaseDN() which were predecessors of getRecord().
Older code was throwing an exception, then catching it and returning null in some places while in other places, the exception was allowed to propagate.
The final change removed the unnecessary exception throwing and swallowing where it was useless. The exception is now thrown again where it is useful.


DraftCNDB.java:
In DraftCNDBCursor(long) ctor, removed throwing the exception and return an empty cursor instead.

DraftCNDbIterator.java:
In DraftCNDbIterator() ctor, throw an exception when the cursor is empty.
2 files modified
22 ■■■■■ changed files
opends/src/server/org/opends/server/replication/server/changelog/je/DraftCNDB.java 11 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/changelog/je/DraftCNDbIterator.java 11 ●●●●● diff | view | raw | blame | history