mirror of https://github.com/luizdepra/hugo-coder.git

Simon Hollingshead
27.37.2023 d66f7cee3cfe75e32f7b28de1d8c75bfe340e896
refs
author Simon Hollingshead <me@simonhollingshead.com>
Monday, February 27, 2023 22:37 +0100
committer GitHub <noreply@github.com>
Monday, February 27, 2023 22:37 +0100
commitd66f7cee3cfe75e32f7b28de1d8c75bfe340e896
tree 7412b44ad54f1ada0a85233e7b5fe8f41e48c636 tree | zip | gz
parent 5c2476be1c29563b6dd06c15fb9206d2ca50efae view | diff
Make H1 sizes consistent between different page types (#777)

### Prerequisites

Put an `x` into the box(es) that apply:

- [x] This pull request fixes a bug.
- [ ] This pull request adds a feature.
- [ ] This pull request introduces breaking change.

### Description

Right now, "article header h1" gets a special larger heading than any
other heading. For consistency's sake, all headings should have the same
size.

This change does not override all H1s otherwise headings generated
halfway down a page with a single '#' in markdown would look weirdly
large. It also does not change all pages to use the article tag, since
the specification states an article must be independently excerpt-able
content, and I would not say that any flavour text above a page listing
is, by itself, an article (e.g. the stuff that you might put as content
for list.html probably doesn't stand alone as an article).

Instead, this chooses to just resize anything which meets the semantic
element of "header h1" (and it adds the semantic element in places where
a header should really be acknowledged as a header, such as on some of
the partials).

### Issues Resolved

https://github.com/luizdepra/hugo-coder/discussions/776

### Checklist

Put an `x` into the box(es) that apply:

#### General

- [x] Describe what changes are being made
- [x] Explain why and how the changes were necessary and implemented
respectively
- [x] Reference issue with `#<ISSUE_NO>` if applicable

#### Resources

- [x] If you have changed any SCSS code, run `make release` to
regenerate all CSS files

#### Contributors

- [x] Add yourself to `CONTRIBUTORS.md` if you aren't on it already
5 files deleted
1 files added
3 files renamed
4 files modified
4082 ■■■■■ changed files
assets/scss/_content.scss 32 ●●●● diff | view | raw | blame | history
layouts/partials/list.html 20 ●●●●● diff | view | raw | blame | history
layouts/partials/terms.html 20 ●●●●● diff | view | raw | blame | history
layouts/posts/list.html 12 ●●●●● diff | view | raw | blame | history
resources/_gen/assets/scss/scss/coder-dark.scss_9e20ccd2d8034c8e0fd83b11fb6e2bd5.content 305 ●●●●● diff | view | raw | blame | history
resources/_gen/assets/scss/scss/coder-dark.scss_9e20ccd2d8034c8e0fd83b11fb6e2bd5.json 1 ●●●● diff | view | raw | blame | history
resources/_gen/assets/scss/scss/coder-dark.scss_e229566deac2466dcd73d10d2fe9546d.content diff | view | raw | blame | history
resources/_gen/assets/scss/scss/coder-dark.scss_e229566deac2466dcd73d10d2fe9546d.json diff | view | raw | blame | history
resources/_gen/assets/scss/scss/coder.scss_38b4d05915c0483e6cb106e4f0efccbc.content 2 ●●● diff | view | raw | blame | history
resources/_gen/assets/scss/scss/coder.scss_38b4d05915c0483e6cb106e4f0efccbc.json 1 ●●●● diff | view | raw | blame | history
resources/_gen/assets/scss/scss/coder.scss_5e1eb8e37c42cdfb6215b61e44dcfa5f.json 1 ●●●● diff | view | raw | blame | history
resources/_gen/assets/scss/scss/coder.scss_fd4b5b3f9a48bc0c7f005d2f7a4cc30f.content 3687 ●●●●● diff | view | raw | blame | history
resources/_gen/assets/scss/scss/coder.scss_fd4b5b3f9a48bc0c7f005d2f7a4cc30f.json 1 ●●●● diff | view | raw | blame | history