mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

neil_a_wilson
18.02.2007 dc7e0efd09b538b9ed21a414dff79fb1cf6f2d64
refs
author neil_a_wilson <neil_a_wilson@localhost>
Friday, May 18, 2007 00:02 +0200
committer neil_a_wilson <neil_a_wilson@localhost>
Friday, May 18, 2007 00:02 +0200
commitdc7e0efd09b538b9ed21a414dff79fb1cf6f2d64
tree 08cc63e73f9f433a1be3b5af832d272877df1d7c tree | zip | gz
parent aaac9d76925b2b15e100e145c1f8a4b781c48a92 view | diff
Perform miscellaneous cleanup from bugs and other potential problems found by
FindBugs

- A couple of cases in which it was possible to reference a variable before it
had been initialized.

- Several cases of unnecessary or inefficient type conversion (e.g., calling
String.toString() or new String(String), or calling new Long(long) instead of
Long.valueOf(long)).

- Several cases of code that was either unused or could not possibly be
reached.

- One case in which an error message was created but not added to an operation
response, and a case in which an exception was created but never thrown.

- Renaming a method in the replication code from "NewChangeNumber()" to
"newChangeNumber()", since method names should start with a lowercase letter.
23 files modified
213 ■■■■ changed files
opends/src/server/org/opends/server/extensions/FIFOEntryCache.java 12 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/extensions/SubschemaSubentryVirtualAttributeProvider.java 1 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/plugins/profiler/ProfileViewer.java 7 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/protocols/jmx/OpendsJmxPrincipal.java 2 ●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/common/ChangeNumber.java 2 ●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/common/ChangeNumberGenerator.java 2 ●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/common/ServerState.java 10 ●●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/plugin/PendingChanges.java 2 ●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/plugin/ReplicationDomain.java 2 ●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/replication/server/ReplicationServer.java 1 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/types/AddressMask.java 2 ●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/types/LDIFImportConfig.java 6 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/util/CertificateManager.java 6 ●●●● diff | view | raw | blame | history
opends/src/server/org/opends/server/util/args/SubCommandArgumentParser.java 2 ●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/DependencyTest.java 20 ●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/SchemaReplicationTest.java 2 ●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/UpdateOperationTest.java 60 ●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/common/ChangeNumberGeneratorTest.java 12 ●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/common/ChangeNumberTest.java 26 ●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/plugin/PersistentServerStateTest.java 4 ●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/plugin/PersistentStateTest.java 4 ●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/server/DbHandlerTest.java 6 ●●●● diff | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/replication/server/ReplicationServerTest.java 22 ●●●● diff | view | raw | blame | history