mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
07.10.2014 df59285898b635c3c9f3011609eb7a73e779ecb9
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Friday, February 7, 2014 11:10 +0100
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Friday, February 7, 2014 11:10 +0100
commitdf59285898b635c3c9f3011609eb7a73e779ecb9
tree dc8bb46e06bc268aa71ddb1a4714e69c50c778a6 tree | zip | gz
parent 6f264162e943a39cab5cb36dd996c7e386c0f59c view | diff
OPENDJ-1307 Migrate server ASN1 classes to SDK 


org.opends.server.protocols.asn1.ASN1* => org.forgerock.opendj.io.ASN1*
ASN1Exception => DecodeException, IOException
ASN1Constants.* => ASN1.*


Straightforward change apart from one change in behaviour:
When calling the OpenDJ server's ASN1*OutputStream.close() method, it was automatically calling close() on the underlying OutputStream, which would in turn clearing and truncate any underlying ByteStringBuilder.
Now, calling the OpenDJ SDK's ASN1*OutputStream.close() method, does not automatically calling close() on the underlying OutputStream. This is more correct because the writer is being fed with the underlying OutputStream at creation time, which means it does not own it.
The fix for this problem consisted in changing the client code calling ASN1*OutputStream.close() method to also clear and truncate the underlying OutputStream and ByteStringBuilder where applicable:
- In ID2Entry.EntryCodec.release()
- LDAPClientConnection.sendLDAPMessage() now calls LDAPClientConnection.ASN1WriterHolder.close()
3 files added
140 files modified
3029 ■■■■ changed files
opendj3-server-dev/src/dsml/org/opends/dsml/protocol/DSMLAddOperation.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/dsml/org/opends/dsml/protocol/DSMLCompareOperation.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/dsml/org/opends/dsml/protocol/DSMLDeleteOperation.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/dsml/org/opends/dsml/protocol/DSMLExtendedOperation.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/dsml/org/opends/dsml/protocol/DSMLModifyDNOperation.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/dsml/org/opends/dsml/protocol/DSMLModifyOperation.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/dsml/org/opends/dsml/protocol/DSMLSearchOperation.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/dsml/org/opends/dsml/protocol/DSMLServlet.java 9 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/backends/jeb/ID2Entry.java 42 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/backends/jeb/JECompressedSchema.java 52 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/AccountUsableRequestControl.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/AccountUsableResponseControl.java 6 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/AuthorizationIdentityResponseControl.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/EntryChangeNotificationControl.java 12 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/EntryChangelogNotificationControl.java 9 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/ExternalChangelogRequestControl.java 9 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/GetEffectiveRightsRequestControl.java 29 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/LDAPAssertionRequestControl.java 6 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/LDAPPostReadRequestControl.java 5 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/LDAPPostReadResponseControl.java 7 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/LDAPPreReadRequestControl.java 5 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/LDAPPreReadResponseControl.java 6 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/MatchedValuesControl.java 6 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/MatchedValuesFilter.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/PagedResultsControl.java 6 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/PasswordExpiredControl.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/PasswordExpiringControl.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/PasswordPolicyRequestControl.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/PasswordPolicyResponseControl.java 6 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/PersistentSearchControl.java 6 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/ProxiedAuthV1Control.java 9 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/ProxiedAuthV2Control.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/ServerSideSortRequestControl.java 8 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/ServerSideSortResponseControl.java 6 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/SubentriesControl.java 6 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/SubtreeDeleteControl.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/VLVRequestControl.java 6 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/controls/VLVResponseControl.java 6 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/core/DefaultCompressedSchema.java 20 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/crypto/GetSymmetricKeyExtendedOperation.java 17 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/extensions/CancelExtendedOperation.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/extensions/GetConnectionIDExtendedOperation.java 12 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/extensions/LDAPPassThroughAuthenticationPolicyFactory.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/extensions/PasswordModifyExtendedOperation.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/extensions/PasswordPolicyStateExtendedOperation.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/plugins/ChangeNumberControlPlugin.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/plugins/profiler/ProfileStack.java 12 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/plugins/profiler/ProfileViewer.java 13 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/plugins/profiler/ProfilerThread.java 12 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/internal/InternalLDAPInputStream.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/internal/InternalLDAPOutputStream.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/ASN1ByteChannelReader.java 575 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/AbandonRequestProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/AddRequestProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/AddResponseProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/BindRequestProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/BindResponseProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/CompareRequestProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/CompareResponseProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/DeleteRequestProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/DeleteResponseProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/ExtendedRequestProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/ExtendedResponseProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/IntermediateResponseProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/LDAPClientConnection.java 50 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/LDAPControl.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/LDAPMessage.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/LDAPReader.java 28 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/LDAPRequestHandler.java 8 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/ModifyDNRequestProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/ModifyDNResponseProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/ModifyRequestProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/ModifyResponseProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/ProtocolOp.java 3 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/SearchRequestProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/SearchResultDoneProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/SearchResultEntryProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/SearchResultReferenceProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/ldap/UnbindRequestProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/replication/common/ServerState.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/replication/plugin/LDAPReplicationDomain.java 8 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/replication/plugin/ReplicationRepairRequestControl.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/replication/protocol/AddMsg.java 17 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/replication/protocol/LDAPUpdateMsg.java 25 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/replication/protocol/ModifyCommonMsg.java 22 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/replication/protocol/ModifyDNMsg.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/replication/protocol/ModifyMsg.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/replication/protocol/MonitorMsg.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/replication/protocol/StartSessionMsg.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/schema/CertificateSyntax.java 48 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/tools/LDAPAuthenticationHandler.java 170 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/tools/LDAPCompare.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/tools/LDAPDelete.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/tools/LDAPModify.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/tools/LDAPPasswordModify.java 86 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/tools/LDAPReader.java 10 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/tools/LDAPSearch.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/tools/LDAPToolUtils.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/tools/LDAPWriter.java 39 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/tools/ManageAccount.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/tools/ManageTasks.java 10 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/tools/StopDS.java 16 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/tools/tasks/TaskClient.java 18 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/tools/tasks/TaskTool.java 11 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/types/Control.java 3 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/types/RawAttribute.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/types/RawFilter.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/types/RawModification.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/TestCaseUtils.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/controls/ExternalChangelogControlTest.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/controls/MatchedValuesControlTest.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/controls/PasswordControlTest.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/controls/PersistentSearchControlTest.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/controls/ProxiedAuthV1ControlTestCase.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/controls/ProxiedAuthV2ControlTestCase.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/controls/VLVControlTestCase.java 27 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/core/SearchOperationTestCase.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/extensions/CancelExtendedOperationTestCase.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/extensions/LDAPPassThroughAuthenticationPolicyTestCase.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/extensions/PasswordModifyExtendedOperationTestCase.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/plugins/DelayPreOpPlugin.java 10 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/plugins/DisconnectClientPlugin.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/plugins/SambaPasswordPluginTestCase.java 4 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/plugins/ShortCircuitPlugin.java 11 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/protocols/ldap/ASN1ByteChannelReaderTestCase.java 304 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/protocols/ldap/ASN1ReaderTestCase.java 853 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/protocols/ldap/TestAbandonRequestProtocolOp.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/protocols/ldap/TestAddRequestProtocolOp.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/protocols/ldap/TestAddResponseProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/protocols/ldap/TestBindRequestProtocolOp.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/protocols/ldap/TestBindResponseProtocolOp.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/protocols/ldap/TestCompareRequestProtocolOp.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/protocols/ldap/TestCompareResponseProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/protocols/ldap/TestDeleteRequestProtocolOp.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/protocols/ldap/TestDeleteResponseProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/protocols/ldap/TestLDAPFilter.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/protocols/ldap/TestModifyDNRequestProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/protocols/ldap/TestModifyDNResponseProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/protocols/ldap/TestModifyRequestProtocolOp.java 6 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/protocols/ldap/TestModifyResponseProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/protocols/ldap/TestSearchProtocolOp.java 15 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/protocols/ldap/TestSearchResultEntryProtocolOp.java 2 ●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/protocols/ldap/TestUnbindRequestProtocolOp.java 6 ●●●● diff | view | raw | blame | history