mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
14.44.2014 ea900ba71bf5eb5e4126583e1852c6982f9ce5a7
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Tuesday, October 14, 2014 17:44 +0200
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Tuesday, October 14, 2014 17:44 +0200
commitea900ba71bf5eb5e4126583e1852c6982f9ce5a7
tree 4435009cdddddc821c5aebd32fc69ead1b00df84 tree | zip | gz
parent d6363de141b6d3a811241967f235331d16fa4c88 view | diff
(CR-4811) Converted opendj3 code to use SearchRequest like API


Requests.java, AbstractRequestImpl.java, SearchRequest.java:
Added to emulate opendj SDK classes.
Augmented the equivalent SDK Requests with some convenience methods, dealing with String/DNs, or String/SearchFilters.

InternalClientConnection.java:
Removed many processSearch() methods.
Only 3 are left:
- processSearch(String baseDN, SearchScope, String filter)
- to be kept
- processSearch(SearchRequest, InternalSearchListener)
- to be kept
- processSearch(ByteString rawBaseDN, SearchScope, DereferenceAliasesPolicy, int sizeLimit, int timeLimit, boolean typesOnly, RawFilter, Set<String> attributes, List<Control> controls, InternalSearchListener)
- Needed by opendj-server3x-adapter, I will get rid of it


For the future, when finally moving to the SDK Filter class, I think there is a little optimization to do. Currently a lot of code is building search filters from static strings, and incurs a parsing cost, but I think it should be possible in many places to statically build filters by using Filter methods like or(), and(), etc. to avoid the cost of parsing the string.
47 files modified
3 files added
3177 ■■■■■ changed files
opendj3-server-dev/src/server/org/opends/server/admin/AdministrationDataSync.java 43 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/authorization/dseecompat/UserAttr.java 32 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/config/JMXMBean.java 132 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/crypto/CryptoManagerImpl.java 97 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/extensions/DynamicGroupSearchThread.java 43 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/extensions/ExactMatchIdentityMapper.java 20 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/extensions/FingerprintCertificateMapper.java 20 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/extensions/PasswordPolicyStateExtendedOperation.java 22 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/extensions/RegularExpressionIdentityMapper.java 20 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/extensions/SubjectAttributeToUserAttributeCertificateMapper.java 20 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/extensions/SubjectDNToUserAttributeCertificateMapper.java 18 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/plugins/ReferentialIntegrityPlugin.java 18 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/plugins/UniqueAttributePlugin.java 16 ●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/internal/AbstractRequestImpl.java 132 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/internal/InternalClientConnection.java 379 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/internal/Requests.java 169 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/protocols/internal/SearchRequest.java 358 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/replication/plugin/LDAPReplicationDomain.java 104 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/replication/plugin/PersistentServerState.java 24 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/backends/ChangelogBackendTestCase.java 58 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/backends/SchemaBackendTestCase.java 50 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/backends/jeb/TestBackendImpl.java 86 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/controls/PersistentSearchControlTest.java 26 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/core/BackendConfigManagerTestCase.java 63 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/core/SearchOperationTestCase.java 104 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/core/networkgroups/ResourceLimitsPolicyTest.java 26 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/crypto/CryptoManagerTestCase.java 26 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/crypto/GetSymmetricKeyExtendedOperationTestCase.java 23 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/extensions/EntityTagVirtualAttributeProviderTestCase.java 12 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/extensions/EntryDNVirtualAttributeProviderTestCase.java 75 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/extensions/EntryUUIDVirtualAttributeProviderTestCase.java 31 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/extensions/ExtensionTestUtils.java 90 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/extensions/GoverningStructureRuleVirtualAttributeProviderTestCase.java 45 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/extensions/HasSubordinatesVirtualAttributeProviderTestCase.java 54 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/extensions/NumSubordinatesVirtualAttributeProviderTestCase.java 115 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/extensions/PasswordExpirationTimeVirtualAttributeProviderTestCase.java 41 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/extensions/PlainSASLMechanismHandlerTestCase.java 11 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/extensions/StructuralObjectClassVirtualAttributeProviderTestCase.java 43 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/extensions/SubschemaSubentryVirtualAttributeProviderTestCase.java 94 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/extensions/UserDefinedVirtualAttributeProviderTestCase.java 79 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/extensions/VirtualStaticGroupTestCase.java 17 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/monitors/InternalSearchMonitorTestCase.java 7 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/plugins/LDAPADListPluginTestCase.java 84 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/plugins/ReferentialIntegrityPluginTestCase.java 12 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/protocols/internal/InternalClientConnectionTestCase.java 86 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/protocols/internal/InternalSearchOperationTestCase.java 72 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/replication/InitOnLineTest.java 10 ●●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/replication/ReplicationTestCase.java 54 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/replication/plugin/AssuredReplicationPluginTest.java 5 ●●●● diff | view | raw | blame | history
opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/tasks/TasksTestCase.java 11 ●●●●● diff | view | raw | blame | history