mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
15.08.2013 f5a806f2303643649722d7303022e2787fbe299b
refs
author Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Monday, April 15, 2013 14:08 +0200
committer Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Monday, April 15, 2013 14:08 +0200
commitf5a806f2303643649722d7303022e2787fbe299b
tree 1db5c5aeb7542d0c83ff0abd71b85403c0a4732c tree | zip | gz
parent 0946c2387ed842a841493a52d43cf49bbd1f614c view | diff
OPENDJ-832 (CR-1545) Leverage the work queue for processing requests received on the HTTP connection handler



Added logging for CONNECT / DISCONNECT operations. All LDAP inner operations are already logged.
Ensured the inner operations are not logged by default.



LDAPClientConnection.java, LDAPConnectionHandler.java:
Moved the disconnect logging from LDAPClientConnection ctor to LDAPConnectionHandler.acceptConnection() in line with other calls to disconnect logging.

HTTPClientConnection.java:
Moved the disconnect logging from HTTPClientConnection ctor to CollectClientConnectionsFilter..doFilter() in line with other calls to disconnect logging.
In sendIntermediateResponseMessage(), throw an exception.
In disconnect(), removed the connection from the connection handler + log the disconnect.

HTTPConnectionHandler.java:
Added addClientConnection() and removeClientConnection().

CollectClientConnectionsFilter.java:
In doFilter(), called HTTPConnectionHandler.addClientConnection() and do not remove the client connection because it is removed when Rest2LDAP calls Connection.close() + called logConnect() + call client disconnect if we sent back the unauthorized status code.

ClientConnection.java
Added isInnerConnection().

Operation.java, AbstractOperation.java, OperationWrapper.java:
Added isInnerOperation() and setInnerOperation().

AbstractTextAccessLogPublisher.java:
Called Operation.isInnerOperation() and ClientConnection.isInnerConnection() instead of checking the connectionID.

AbstractTextAccessLogPublisherTest.java:
Updated the test.

SdkConnectionAdapter.java
In enqueueOperation(), setInnerOperation().
In close(UnbindRequest, String), do not issue run the UnbindOperation if we were not authenticated, but issue a disconnect log message.
12 files modified
337 ■■■■■ changed files
opendj-sdk/opends/src/server/org/opends/server/api/ClientConnection.java 50 ●●●●● diff | view | raw | blame | history
opendj-sdk/opends/src/server/org/opends/server/core/OperationWrapper.java 20 ●●●●● diff | view | raw | blame | history
opendj-sdk/opends/src/server/org/opends/server/loggers/AbstractTextAccessLogPublisher.java 24 ●●●● diff | view | raw | blame | history
opendj-sdk/opends/src/server/org/opends/server/protocols/http/CollectClientConnectionsFilter.java 19 ●●●● diff | view | raw | blame | history
opendj-sdk/opends/src/server/org/opends/server/protocols/http/HTTPClientConnection.java 25 ●●●●● diff | view | raw | blame | history
opendj-sdk/opends/src/server/org/opends/server/protocols/http/HTTPConnectionHandler.java 32 ●●●●● diff | view | raw | blame | history
opendj-sdk/opends/src/server/org/opends/server/protocols/http/SdkConnectionAdapter.java 25 ●●●● diff | view | raw | blame | history
opendj-sdk/opends/src/server/org/opends/server/protocols/ldap/LDAPClientConnection.java 5 ●●●●● diff | view | raw | blame | history
opendj-sdk/opends/src/server/org/opends/server/protocols/ldap/LDAPConnectionHandler.java 3 ●●●● diff | view | raw | blame | history
opendj-sdk/opends/src/server/org/opends/server/types/AbstractOperation.java 61 ●●●●● diff | view | raw | blame | history
opendj-sdk/opends/src/server/org/opends/server/types/Operation.java 25 ●●●●● diff | view | raw | blame | history
opendj-sdk/opends/tests/unit-tests-testng/src/server/org/opends/server/loggers/AbstractTextAccessLogPublisherTest.java 48 ●●●● diff | view | raw | blame | history