mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Gaetan Boismal
27.02.2015 fc9ea80534451bf31b248056efe5692a1a3b51a2
refs
author Gaetan Boismal <gaetan.boismal@forgerock.com>
Monday, July 27, 2015 11:02 +0200
committer Gaetan Boismal <gaetan.boismal@forgerock.com>
Monday, July 27, 2015 11:02 +0200
commitfc9ea80534451bf31b248056efe5692a1a3b51a2
tree 8619561fce5f1a6a769aa5f1ca6095888b37c046 tree | zip | gz
parent cbc5fe974288afb724eabbca7e6dd271d6624f3f view | diff
OPENDJ-2027 CR-7646 Change tools message on error

This commit makes all tools consistent in the way that if no arguments are provided on the command line (or only the non prompt argument for interactive tools), tool prints the error and the help reference message on error stream.
Changes details:
* ArgumentParser
** Create method displayMessageAndUsageReference(), this method is used by tools to print both an error message and the help usage reference message
** getHelpUsageReference() has been moved from SubCommandArgumentParser

* DSConfig
** displayErrorMessageAndUsageReference() has been moved to ArgumentParser

* CreateRCScript
** Moves the server root path check after the argument parsing in order to have a consistent error message if arguments are invalid.

* RebuildIndex
* VerifyIndex
** Removed dead code which printed usage if no args were provided (if so, an argument exception is raised before).

* MakeLDIF
** Add a main method for test purpose

* ArgumentParserToolsTestCase
** Test that tools are consistent if an invalid argument is provided or if no args are provided.

Tools modified by this commit are the following:
Server tools
* Does not print usage anymore
** backup
** base64 (only if no args are provided)
** control-panel
** create-rc-script
** dbtest
** dsjavaproperties
** dsreplication
** encode-password
** export-ldif
** import-ldif
** ldapcompare
** ldapdelete
** ldapmodify
** ldappasswordmodify
** ldapsearch
** ldif-diff
** ldifmodify
** ldifsearch
** make-ldif
** manage-account
** manage-tasks
** rebuild-index
** restore
** setup
** start-ds
** status
** stop-ds
** uninstall
** upgrade
** verify-index

* Usage reference message added
** base64 (only if invalid args are provided)

SDK tools
* Does not print usage anymore
** addrate
** makeldif

* Usage reference message added
** authrate
** ldapcompare
** ldapmodify
** ldappasswordmodify
** ldapsearch
** ldifdiff
** ldifmodify
** ldifsearch
** modrate
** searchrate
1 files added
61 files modified
859 ■■■■■ changed files
opendj-sdk/opendj-cli/src/main/java/com/forgerock/opendj/cli/ArgumentParser.java 29 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-cli/src/main/java/com/forgerock/opendj/cli/ConsoleApplication.java 2 ●●● diff | view | raw | blame | history
opendj-sdk/opendj-cli/src/main/java/com/forgerock/opendj/cli/SubCommandArgumentParser.java 14 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-config/src/main/java/org/forgerock/opendj/config/dsconfig/DSConfig.java 20 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/AddRate.java 3 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/AuthRate.java 3 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDAPCompare.java 21 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDAPModify.java 3 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDAPPasswordModify.java 3 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDAPSearch.java 6 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDIFDiff.java 3 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDIFModify.java 3 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDIFSearch.java 6 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/MakeLDIF.java 3 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/ModRate.java 3 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/SearchRate.java 3 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-ldap-toolkit/src/test/java/com/forgerock/opendj/ldap/tools/AddRateITCase.java 4 ●●● diff | view | raw | blame | history
opendj-sdk/opendj-ldap-toolkit/src/test/java/com/forgerock/opendj/ldap/tools/AuthRateITCase.java 2 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-ldap-toolkit/src/test/java/com/forgerock/opendj/ldap/tools/LDAPCompareITCase.java 7 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-ldap-toolkit/src/test/java/com/forgerock/opendj/ldap/tools/LDAPSearchITCase.java 7 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-ldap-toolkit/src/test/java/com/forgerock/opendj/ldap/tools/MakeLDIFITCase.java 11 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ControlPanelLauncher.java 5 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/guitools/uninstaller/UninstallCliHelper.java 22 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/guitools/uninstaller/UninstallLauncher.java 6 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/quicksetup/installer/SetupLauncher.java 6 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/backends/jeb/DBTest.java 6 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/core/DirectoryServer.java 8 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/plugins/profiler/ProfileViewer.java 6 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/BackUpDB.java 30 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/ConfigureDS.java 7 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/ConfigureWindowsService.java 9 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/CreateRCScript.java 23 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/EncodePassword.java 11 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/ExportLDIF.java 3 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/ImportLDIF.java 13 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/InstallDS.java 5 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/JavaPropertiesTool.java 6 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPCompare.java 8 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPDelete.java 16 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPModify.java 16 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPPasswordModify.java 18 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPSearch.java 14 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/LDIFDiff.java 3 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/LDIFModify.java 3 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/LDIFSearch.java 6 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/ListBackends.java 3 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/ManageAccount.java 6 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/ManageTasks.java 4 ●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/RebuildIndex.java 33 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/RestoreDB.java 3 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/StopDS.java 6 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/VerifyIndex.java 14 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/WaitForFileDelete.java 5 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/dsreplication/ReplicationCliMain.java 32 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/makeldif/MakeLDIF.java 22 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/status/StatusCli.java 30 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/tasks/TaskTool.java 8 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/tools/upgrade/UpgradeCli.java 11 ●●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/util/Base64.java 2 ●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/util/EMailMessage.java 2 ●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/main/java/org/opends/server/util/args/LDAPConnectionArgumentParser.java 28 ●●●● diff | view | raw | blame | history
opendj-sdk/opendj-server-legacy/src/test/java/org/opends/server/tools/ArgumentParserToolsTestCase.java 244 ●●●●● diff | view | raw | blame | history