Fix OPENDJ-975: REST DELETE fails with HTTP result code 404 but it http-acc...

Matthew Swift

14.10.2013 1f5f947ffb9419c9d33ef58a4099ed915da5bf1a

Fix OPENDJ-975: REST DELETE fails with HTTP result code 404 but it http-access it is 200

Close the request processing context after invoking the result handlers not before since the handler may need to interact with context before it is closed. In this case closing the context logged result before the handler had a chance to update the internal error state.

 opendj-sdk/opendj3/opendj-rest2ldap/src/main/java/org/forgerock/opendj/rest2ldap/LDAPCollectionResourceProvider.java

@@ -920,8 +920,11 @@
        return new QueryResultHandler() {
            @Override
            public void handleError(final ResourceException error) {
                c.close();
                handler.handleError(error);
                try {
                    handler.handleError(error);
                } finally {
                    c.close();
                }
            }

            @Override
@@ -931,8 +934,11 @@

            @Override
            public void handleResult(final QueryResult result) {
                c.close();
                handler.handleResult(result);
                try {
                    handler.handleResult(result);
                } finally {
                    c.close();
                }
            }
        };
    }
@@ -941,14 +947,20 @@
        return new ResultHandler<V>() {
            @Override
            public void handleError(final ResourceException error) {
                c.close();
                handler.handleError(error);
                try {
                    handler.handleError(error);
                } finally {
                    c.close();
                }
            }

            @Override
            public void handleResult(final V result) {
                c.close();
                handler.handleResult(result);
                try {
                    handler.handleResult(result);
                } finally {
                    c.close();
                }
            }
        };
    }