Add a test case for unbind operations, and update the operation test case t...

neil_a_wilson

04.50.2006 2016f41c2dc0c7c9f41431222289b4711dc6e9ae

Add a test case for unbind operations, and update the operation test case to
cover the addResponseControl and removeResponseControl methods.

 opends/tests/unit-tests-testng/src/server/org/opends/server/core/OperationTestCase.java

@@ -33,6 +33,7 @@
import org.testng.annotations.Test;

import org.opends.server.TestCaseUtils;
import org.opends.server.types.Control;
import org.opends.server.types.ResultCode;

import static org.testng.Assert.*;
@@ -381,5 +382,26 @@
  {
    assertNotNull(operation.toString());
  }



  /**
   * Tests the <CODE>addResponseControl</CODE> and
   * <CODE>removeResponseControl</CODE> methods.
   *
   * @param  operation  The operation to test.
   */
  @Test(dataProvider = "testOperations")
  public void testAddAndRemoveResponseControl(Operation operation)
  {
    Control c = new Control("1.2.3.4", false);
    operation.addResponseControl(c);
    operation.removeResponseControl(c);

    if (operation.getResponseControls() != null)
    {
      assertFalse(operation.getResponseControls().contains(c));
    }
  }
}


 opends/tests/unit-tests-testng/src/server/org/opends/server/core/UnbindOperationTestCase.java

New file
@@ -0,0 +1,161 @@
/*
 * CDDL HEADER START
 *
 * The contents of this file are subject to the terms of the
 * Common Development and Distribution License, Version 1.0 only
 * (the "License").  You may not use this file except in compliance
 * with the License.
 *
 * You can obtain a copy of the license at
 * trunk/opends/resource/legal-notices/OpenDS.LICENSE
 * or https://OpenDS.dev.java.net/OpenDS.LICENSE.
 * See the License for the specific language governing permissions
 * and limitations under the License.
 *
 * When distributing Covered Code, include this CDDL HEADER in each
 * file and include the License file at
 * trunk/opends/resource/legal-notices/OpenDS.LICENSE.  If applicable,
 * add the following below this CDDL HEADER, with the fields enclosed
 * by brackets "[]" replaced with your own identifying * information:
 *      Portions Copyright [yyyy] [name of copyright owner]
 *
 * CDDL HEADER END
 *
 *
 *      Portions Copyright 2006 Sun Microsystems, Inc.
 */
package org.opends.server.core;



import java.util.ArrayList;

import org.testng.annotations.Test;

import org.opends.server.TestCaseUtils;
import org.opends.server.plugins.InvocationCounterPlugin;
import org.opends.server.protocols.internal.InternalClientConnection;
import org.opends.server.types.CancelRequest;
import org.opends.server.types.CancelResult;
import org.opends.server.types.Control;

import static org.testng.Assert.*;

import static org.opends.server.util.ServerConstants.*;



/**
 * A set of test cases for unbind operations
 */
public class UnbindOperationTestCase
       extends OperationTestCase
{
  /**
   * {@inheritDoc}
   */
  @Override()
  public Operation[] createTestOperations()
         throws Exception
  {
    InternalClientConnection conn =
         InternalClientConnection.getRootConnection();

    return new Operation[]
    {
      new UnbindOperation(conn, conn.nextOperationID(), conn.nextMessageID(),
                          null),
      new UnbindOperation(conn, conn.nextOperationID(), conn.nextMessageID(),
                          new ArrayList<Control>())
    };
  }



  /**
   * Invokes a number of operation methods on the provided unbind operation for
   * which all processing has been completed.
   *
   * @param  unbindOperation  The operation to be tested.
   */
  private void examineCompletedOperation(UnbindOperation unbindOperation)
  {
    assertTrue(unbindOperation.getProcessingStartTime() > 0);
    assertTrue(unbindOperation.getProcessingStopTime() > 0);
    assertTrue(unbindOperation.getProcessingTime() >= 0);
    assertNotNull(unbindOperation.getResponseLogElements());
  }



  /**
   * Attempts an internal unbind operation.  This won't actually do anything,
   * since there's nothing to disconnect with an internal connection, but it
   * will at least exercise the code path.
   */
  @Test()
  public void testUnbindInternal()
  {
    InvocationCounterPlugin.resetAllCounters();

    InternalClientConnection conn =
         InternalClientConnection.getRootConnection();

    UnbindOperation unbindOperation =
         new UnbindOperation(conn, conn.nextOperationID(),
                             conn.nextMessageID(), new ArrayList<Control>());
    unbindOperation.run();
    examineCompletedOperation(unbindOperation);

    assertTrue(InvocationCounterPlugin.getPreParseCount() > 0);
    assertTrue(InvocationCounterPlugin.getPostOperationCount() > 0);
  }



  /**
   * Tests the <CODE>cancel</CODE> method to ensure that it indicates that the
   * operation cannot be cancelled.
   */
  @Test()
  public void testCancel()
  {
    InternalClientConnection conn =
         InternalClientConnection.getRootConnection();

    CancelRequest cancelRequest =
         new CancelRequest(false, "Test Unbind Cancel");

    UnbindOperation unbindOperation =
         new UnbindOperation(conn, conn.nextOperationID(),
                             conn.nextMessageID(), new ArrayList<Control>());
    assertEquals(unbindOperation.cancel(cancelRequest),
                 CancelResult.CANNOT_CANCEL);
  }



  /**
   * Tests the <CODE>getCancelRequest</CODE> method to ensure that it always
   * returns <CODE>null</CODE>.
   */
  public void testGetCancelRequest()
  {
    InternalClientConnection conn =
         InternalClientConnection.getRootConnection();

    CancelRequest cancelRequest =
         new CancelRequest(false, "Test Unbind Cancel");

    UnbindOperation unbindOperation =
         new UnbindOperation(conn, conn.nextOperationID(),
                             conn.nextMessageID(), new ArrayList<Control>());
    assertNull(unbindOperation.getCancelRequest());

    assertEquals(unbindOperation.cancel(cancelRequest),
                 CancelResult.CANNOT_CANCEL);

    assertNull(unbindOperation.getCancelRequest());
  }
}